Wizcorp / phonegap-facebook-plugin

The official plugin for Facebook in Apache Cordova/PhoneGap
Other
1.91k stars 2.01k forks source link

Disable loading spinner on Login in Android #916

Open rudza opened 9 years ago

rudza commented 9 years ago

I am using custom loading spinner in my so now, after updating plugin - these two are showing together.

kiempoturner commented 9 years ago

same here

aogilvie commented 9 years ago

@rudza "so"? Please give us a screen shot and Android OS version.

bostondv commented 9 years ago

I'm also looking for an option to hide the spinner when calling the login method as I'm using my own loading spinner.

Version: Android 5.0.1 Nexus 5

Screenshot shows the native Android spinner (circular icon) that's added by the plugin overlapping my custom loading UI ("Loading..." text inside rounded rectangle).

screenshot_2015-02-24-15-08-48

DhavalDatar commented 9 years ago

Specify android:theme="@android:style/Theme.NoDisplay" in Manifest file where you have declared com.facebook.FacebookActivity / com.facebook.LoginActivity

bostondv commented 9 years ago

Thanks for the tip! Is it possible to change this via config.xml though? I'd like to avoid editing the manifest since those changes are lost anytime removing the platform or plugin.

GustavoCostaW commented 9 years ago

This tag in AndroidManifest.xml is add automatically by plugin.xml, for customize change

        <activity android:label="@string/fb_app_name" android:name="com.facebook.LoginActivity" android:theme="@android:style/Theme.NoDisplay"></activity> 

Line 48

thx @DhavalDatar for help.

ayyazzafar commented 8 years ago

I am also facing same issue.

How can I disable that spinner in phonegap build using config.xml ?

Xwalk-Company commented 8 years ago

When change the line 48 (for customize), AndroidManifext.xml add the old line (with Translucent.NoTitleBar...) and cause a crash. I can not know where it is added spinnerandroidfb

Xwalk-Company commented 8 years ago

Work for me with remove platform android, clone the git and update the file before add plugin on cordova cli

ebarault commented 8 years ago

there is currently no way you can change this with the regular config.xml one solution could be to use some hooks, just as in this plugin another solution is to create a custom plugin with merely only a plugin.xml file that you install right at the end of your other plugins and that will carry the lines for changing the spinner style

ebarault commented 8 years ago

on Android 6, you will nevertheless encounter a bug when changing theme to NoDisplay: see this link your app will crash with an IllegalStateException saying that your activity “did not call finish() prior to onResume() completing”. This, apparently, is a new requirement of Theme.NoDisplay activities.

this would require some mods in the plugin's android code for this to work

apstory commented 7 years ago

Has the plugin been updated to remove the loader?

assaf13 commented 7 years ago

When the plugin should updated in order to remove the loader?

rudza commented 7 years ago

Looks like the package is not being supported anymore. 397 issues & last update 2 years ago.