search

Wizcorp / phonegap-plugin-iRate

PhoneGap plugin for customer/client app rating. [iOS ONLY]
MIT License
7 stars 6 forks source link

iOS8 Appstore Rating URL Format #6

Open an-rahulpandey opened 9 years ago

jrouault commented 9 years ago

Hello! First of all, thanks for your PR! It's always nice to see some contributions. :+1:

Could you give (or link) explanations describing that the URL changed for iOS 8?

Could you review your code style (camelCase, space after comma) too please? As well, I would rather see this for the condition checking:

    if (deviceVersion >= 8.0) {
        [...]
    }
    else if (deviceVersion >= 7.0) {
        [...]
    }

    reviewURL = [NSString stringWithFormat:iRateiOSAppStoreURLFormat, self.appStoreID];
    return [NSURL URLWithString:reviewURL];

Last, [UIDevice currentDevice].systemVersion is no longer the recommended way to check against the system version. If you can change it that's cool, otherwise I will happily do it in another PR.

Edit: I just saw you drop this @(self.appStoreID) for this self.appStoreID. Is the conversion still done correctly? Could you restore it?