search

Wizcorp / tina.js

Tweening and INterpolations for Animation
MIT License
12 stars 8 forks source link

annoying warning when stopping a non running tween #39

Open polco opened 8 years ago

polco commented 8 years ago

Calling silent(true) on the tweener doesn't remove the warning when calling stop on a tween that is not running. '[Playable.stop] Cannot stop a playable that is not running'

bchevalier commented 8 years ago

This should be fixed, let me know if not.

polco commented 8 years ago

so from what I tried, if i use the the method getDefaultTweener and try calling silent(true) it doesn't turn off the warnings. If I created my own Tweener new TINA.Timer(1000), there is no more warning with or without calling silent(true). Maybe you should document this API on your readme by the way ! Anyway, i finally have a clean console log, thanks :dancer:

bchevalier commented 8 years ago

Thanks for the details. Actually I tried to reproduce the issue you describe but it seems to work properly. The code I tested is the following:

    var defaultTweener = TINA.getDefaultTweener();
    defaultTweener.silent(true);

    var myArray = [0, 1, 2];
    var myTween = TINA.Tween(myArray)
        .to([0, 2, 4], 300)
        .start();

    myTween.stop();
    myTween.stop();

No warning popped up.

Could you share the code for which you have the issue?