Wnayar / pe

0 stars 0 forks source link

Clear feature has no additional input validation for extra arguments provided #14

Open Wnayar opened 4 days ago

Wnayar commented 4 days ago

Steps to reproduce: clear 1

image.png

Expected output: Expect a feedback message to tell the user if he is sure to clear. Actual Output: Instead it accepts the input clear 1 and deletes all data. This is a big feature flaw problem , as the user may assume clear 1 is to delete the first user or delete the list of persons. Thus for such critical operations, there should be strict data validation, such as ensuring the user types exactly clear, and not clear with additional arguments. Furthermore your application has no way to undo this, making the clear feature even more critical and should definitely have stronger data validation. image.png

nus-pe-script commented 1 day ago

Team's Response

This is actually intended behaviour, as the clear command normally ignores extra parameters. And technically, we already have clearly-named delete commands for purposes of single-entry deletion.

About your point of input validation, the clear command is very clearly stated in the UG as deleting every entry permanently, even giving a warning there. So we deem input validation as unnecessary.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]