Tooltip model preview stutters during mouseover of reward item in a quest panel

WoW-MogIt / MogIt

World of Warcraft transmogrification assistant

https://www.curseforge.com/wow/addons/mogit

11 stars 15 forks source link

Tooltip model preview stutters during mouseover of reward item in a quest panel #22

Closed ryankhart closed 11 months ago

ryankhart commented 1 year ago

I have also tested and confirmed that this bug exists even when all other addons are disabled.

Animation

Lombra commented 1 year ago

This issue has been coming and going. (or maybe just staying, I'm not sure) I'll see if I can get to the bottom of it.

ripsteakface9000 commented 1 year ago

Issue is still reproducing for me with MogIt v3.10.0.

ahazanov commented 1 year ago

The issue is at https://github.com/WoW-MogIt/MogIt/blob/master/Core/Tooltip.lua#L92. For some reason the two links being compared are not exactly the same, even though they are for the same item ID / name. Extracting the item IDs and comparing those gets rid of the stutter.

I replaced the line locally with this naive fix, seems to work:

if not (tooltip.item and tooltip.item:match("item:" .. itemID .. ":")) then

Faulkal commented 11 months ago

this is the answer! thank you so much for this!