WoWManiaUK / Redemption

WoW-Mania - Redemption - 3.3.5 PvE Realm
https://wow-mania.com/
52 stars 28 forks source link

[Spell] Death Knight- Offhand Frost Strike and Threat of Thassarian interaction #5358

Closed Kilju closed 3 years ago

Kilju commented 3 years ago

Links: https://www.wow-mania.com/armory/?spell=55268 https://www.wow-mania.com/armory/?spell=66192 https://www.wow-mania.com/armory/?spell=50138

What is Happening: DK ability Frost Strike while dual wielding is hitting with 100% damage with main hand and offhand.

What Should happen: Main hand attack should do 100% of damage. Offhand attacks should suffer 50% damage penalty that can be mitigated with Nerves of Steel talent that increases offhand damage by 25%, therefore bringing offhand damage to 62,5% before other damage increasing talents are taken into consideration. This particular interaction was reported also on Blackwing Lair server. Talent is not changed in cataclysm, FS damage % is buffed in cataclysm. https://github.com/WoWManiaUK/Blackwing-Lair/issues/2531

Some screenshots, they are not 100% same due to RNG. Both MH and OH weapons were identical

WoWScrnShot_030921_152500 Second crit should be around 2555 with rough math if you calculate it from the first strike.

WoWScrnShot_030921_150614

WoWScrnShot_030921_152356 Second hit should be 2562 if you calculate it from MH. Obviously its calculated from offhand damage but to illustrate that its not 62,25%

festerhowl commented 3 years ago

Obviously its calculated from offhand damage

Exactly. Might need to crunch some numbers to check if its impossible for off-hand to hit 3808. If in case it is possible to hit that number with off-hand then the question arises if the main hand is indeed doing 100% damage.

svijetlo commented 3 years ago

so after some testing i can openly say this only happen for Frost strike did all test wo Oh dmg mod talent so just Threat of Thassarian so i did some hits lot of them with death strike those are cca numbers , (scared to post lot of ss so github does not lock me again) i also used crap weapons' to exclude any other effect and char was lvl 60 still death strike OH dmg 142 - Mh dmg 298 plague strike OH 130 - Mh 305 blood strike OH 232 -Mh 540 FROST STRIKE OH 790 - mh 940 i made small fight act on dummy and will post ss image i use addon for dmg Details so it counts MH and OH hit as same spell but in different bars

festerhowl commented 3 years ago

Screenshot (167) ~~could it be that the tooltip isn't updated and therefore causing confusion regarding the damage modifier of OH frost strike? I found this at https://wowwiki-archive.fandom.com/wiki/Threat_of_Thassarian i am not entirely sure about this whole thing as there arent many patch notes regarding this spell. All i see is a jump from patch 3.2.2 to 5.0.8 and nothing other than only the tooltip of the talent changing. If in case it is possible, maybe the OH frost strike is supposed to do 75%(50% OH+ 25% ToT)?~~

Kilju commented 3 years ago

Warlords of Draenor Patch 6.0.2 (2014-10-14): Removed. Effects merged into [Might of the Frozen Wastes]. Mists of Pandaria Hotfix (2013-03-05): "Threat of Thassarian now increases the damage of Frost Strike by 50% (was 40%)." Mists of Pandaria Patch 5.0.4 (2012-08-28): Now given automatically to Frost death knights. No longer affects Rune Strike or Blood Strike, and causes Frost Strike to deal an additional 50% damage when dual wielding. Wrath of the Lich King Patch 3.2.2 (2009-09-22): Threat of Thassarian now also causes Rune Strike to use both weapons when dual-wielding. Wrath of the Lich King Patch 3.2.0 (2009-08-04): Added.

https://wow.gamepedia.com/Patch_5.0.4_(class_changes) https://wow.gamepedia.com/Threat_of_Thassarian

So it was changed later on.

svijetlo commented 3 years ago

As kilju told change and my look around show it changes came much later

Aristo14 commented 3 years ago

I'm not a tester but I get some different results;

fstestuntalented1

fstestuntalented2

fstestuntalented3

This is without https://www.wow-mania.com/armory/?spell=50138

The weird thing is that this is actually very close to the 62,5% even without the talent.

Aristo14 commented 3 years ago

fstestnerves1

fstestnerves2

fstestnerves3

This is WITH https://www.wow-mania.com/armory/?spell=50138

Same numbers overall 205mh and 135oh and again around 62,5%

I tested without gear and statless weapons, without any talent interacting with FS or dmg.

fstesttree1 fstesttree2

To me it seems to be working correctly WITH talent but not correct WITHOUT.

jeyrella commented 3 years ago

So, since the above is on live... what is it that we have actually fixed on PTR, if it wasn't broken in the way we thought it was?

Janitor, pls do not push this one live yet. I want to make sure to do more research/digging/testing to have 100% confidence we're doing the correct thing here.

Aristo14 commented 3 years ago

Screenshot_4

Screenshot_4

Obliterate, Blood Strike, Death Strike do not seem to interact with Screenshot_6

Screenshot_7

Obliterate, Blood Strike, Death Strike and Plague Strike do not seem to interact with it at all.

all tested same way and with the https://www.wow-mania.com/armory/?spell=50138 and https://www.wow-mania.com/armory/?spell=66192

jeyrella commented 3 years ago

This sounds like we're fixing the wrong thing, and maybe accidentally getting a better result?

I don't know DKs so @svijetlo @hawker357 I need your full input on this one.

Aristo14 commented 3 years ago

Frost Strike seems to interact with https://www.wow-mania.com/armory/?spell=66192 + https://www.wow-mania.com/armory/?spell=50138 correctly to a 62,5% offhand level.

Frost Strike seems to interact with the Nerves of Cold Steel even untalented.

Obliterate, Plague Strike, Blood Strike and Death Strike do not seem to interact with nerves of cold steel at all and are even below a 50% off hand dmg level.

The proposed issue was posted with gear etc and critted.. this might be related to crit but not the talents or abilities. (lot of posible interactions with the dmg outcome)

Keader commented 3 years ago

"Description: When dual-wielding, your Death Strikes, Obliterates, Plague Strikes, Rune Strikes, Blood Strikes and Frost Strikes have a $s1% chance to also deal damage with your offhand weapon."

The issue here is about Threat of Thassarian making frost strike (OFF HAND) do ~100% of damage, like main hand. And it's fixed. If damage of frost strike (main spell) is wrong, it belong to another issue.

Aristo14 commented 3 years ago

Well on live my tests show it doesnt do 100% but the 62,5% regardless of having nerves of cold steel talented or not.

Threat of Thassarian only makes it so that it actually hits with OH as well and on most abilities it doesnt even do 50%

festerhowl commented 3 years ago

I didn't really think about doing my own research on this matter as @svijetlo had already confirmed the bug but i had to now after @Aristo14 provided new screenshots. I didn't use any talents that could affect damage on any of my abilities and i unequipped all gear and bought 2x Cutlass from stormwind city. Here are my results: Screenshot (203)

  1. Without Nerves of Cold Steel:

Screenshot (201)

The off-hand damage of Frost strike seems roughly around 62.5% without the talent when it should be 50%

  1. With Nerves of Cold Steel:

Screenshot (204)

The off-hand Frost strike is still roughly 62.5% when the talent is taken and is therefore working as intended on live. pls revert any changes that may have been made to this spell. The problem now is not how the off-hand frost strike is doing 100% damage but rather why it is doing 62.5% damage without nerves of cold steel when it should be 50%

I also noticed that plague strike, obliterate, blood strike and death strike off hand are doing less than 50% damage even when nerves of steel is taken, I will make a new report with the relevant screenshots unless @Aristo14 wants to.

Aristo14 commented 3 years ago

You came to exact same results @festerhowl thanks. I don't see how we can show it more clearly.

Keader commented 3 years ago

Fuck this shit, you guys dont even know what is wrong or not, giving me wrong information. I will not touch on this anymore, reverting everything.

svijetlo commented 3 years ago

close post and in future if ppl are not sure and do not provide correct data form back in time i will not test it , sorry but you burn everyone time and i am not personal escort or personal tester for anyone nor is any GM , dev or tester =) with all do respect where respect is to be given

Keader commented 3 years ago

Will be reverted tomorrow (i cant build tonight)