WoWManiaUK / Redemption

WoW-Mania - Redemption - 3.3.5 PvE Realm
https://wow-mania.com/
52 stars 29 forks source link

[Item Proc Buff] Last Word has 30-sec ICD on equip #6182

Closed YggdrasilWotLK closed 5 months ago

YggdrasilWotLK commented 6 months ago

Links: https://www.wowhead.com/wotlk/item=50179/last-word#dropped-by https://www.wow-mania.com/armory/?item=50708

What is Happening: Last Word is a mace with a buff proc with a 37% proc rate per 1.80 swing. It will usually proc within five swings, and has an uptime of some 90+%. However, it does not proc for 30 seconds after equipping, similar to how Libram of Defiance and Libram of Divine Purpose acted before their respective fixes (re. https://github.com/WoWManiaUK/Redemption/issues/4952 and https://github.com/WoWManiaUK/Redemption/issues/4673).

What Should happen: Like other weapon slot items with a proc, Last Word should not have an ICD. Re Trauma, Val'anyr (which I see has a separate fix here: https://github.com/WoWManiaUK/Redemption/issues/2842), paladin librams, etc., to name a few.

Maine1 commented 6 months ago

Can confirm this is having a 30 second CD on equip which shouldn't be there.

Rushor commented 6 months ago

30 sec cd should no longer be there on equip

Echinaceax commented 6 months ago

fixed in PTR https://i.gyazo.com/8cfba8291f711effb3666f759a4243d3.mp4

Echinaceax commented 6 months ago

@Rushor The fix you did for the normal version has to be done for the HC also 50708 please

Rushor commented 6 months ago

Yes will add all Version, Label was wrong yet

Rushor commented 5 months ago

fixed for both versions now

Maine1 commented 5 months ago

@Rushor ICD on item equip is fixed. Last Word Heroic ID 50708 Doesn't say Heroic on the tooltip anymore. image

Rushor commented 5 months ago

that tooltip thing was not changed by me - so not related to this fix. my fix works for the issue above

Echinaceax commented 5 months ago

that tooltip thing was not changed by me - so not related to this fix. my fix works for the issue above

this was showing HC when i checked it here on this report 3 weeks ago, something changed somewhere @Rushor

fixed in PTR https://i.gyazo.com/8cfba8291f711effb3666f759a4243d3.mp4

image

Rushor commented 5 months ago

okay fixed with next restart and cache clear

Echinaceax commented 5 months ago

okay fixed with next restart and cache clear

All fixed again, thanks Rushor https://i.gyazo.com/66c653bc8f25f22b584c8146182628e2.mp4