WoWManiaUK / Redemption

WoW-Mania - Redemption - 3.3.5 PvE Realm
https://wow-mania.com/
52 stars 29 forks source link

Nevermelting Ice Crystal loses stacks with any crit and not just spell crits. #6191

Closed L0dos closed 4 months ago

L0dos commented 4 months ago

Links: https://www.wowhead.com/wotlk/item=50259/nevermelting-ice-crystal

What is Happening: Loses stacks with any type of crit regardless it's a spell or not.

What Should happen: One of the GMs back then changed this item to lose stacks with any type of crit cause i was using it as a hunter. He said there should be a seperate spell crit stat in the game and i think there should be an item in the game allows hunters to do 10000000000000k damage. Please fix it to how it should work.

Maine1 commented 4 months ago

@L0dos Does this also lose stacks on ranged normal weapon white crits? If it loses crit stacks on aimed shot and chimera shot etc then these are still spells

https://github.com/WoWManiaUK/Redemption/issues/2067

L0dos commented 4 months ago

Loses stacks with basic attack cirts or any crit. Hunter abilities or shots doesn't count as spells for trinkets if so u would be able to pop caster trinkets with them which u can't and also if so u would benefit from spell power.

Maine1 commented 4 months ago

Any attack that is not a white attack count as a spell. even the abilities from warriors and rogues are classed as spells

L0dos commented 4 months ago

Try to proc Screenshot_3 with a rogue then.

Maine1 commented 4 months ago

I cannot go around testing all items. They ofcourse have specifics based on how blizzard set them to back then.

Echinaceax commented 4 months ago

Internally reported @Rushor https://github.com/fvicaria/WoW-Mania/issues/9

L0dos commented 4 months ago

https://github.com/WoWManiaUK/Redemption/assets/33573664/b6811880-4ece-4c36-8d03-8950728cf8aa

L0dos commented 4 months ago

https://github.com/WoWManiaUK/Redemption/assets/33573664/a4f64c4e-b655-4156-8ee8-009943c5cda3

Echinaceax commented 4 months ago

i have spoken to reporter regarding this issue and shared my findings also with them. we deem this working as it should, with multiple tests over 2 days. as stated by maine we cannot test every item to make the comparision to fit the report.

Hunter (auto shot) https://i.gyazo.com/6723ae16a56ef627b5a11f95ad7b2758.mp4

Mage (auto shoot) 6-7 (hit) 0 amount drop (only on the white crits 10s) https://i.gyazo.com/f5f84f5f182bfc2c82ed23c685d5b5a9.mp4 crits/none crits https://i.gyazo.com/cf481e99b90ab56faf05fbc36f6a7bbf.mp4

Hajzlopuc commented 4 months ago

Any attack that is not a white attack count as a spell. even the abilities from warriors and rogues are classed as spells

What??? This is so wrong, are you even serious?

we deem this working as it should

How can you deem this "working as it should" when your own 3 videos prove the opposite?

Trinket shouldn't lose stacks from any attacks at all... White, yellow, crit or non-crit... anything that requires weapon is an attack. Just because it's yellow and can do magic damage, doesn't mean it's a spell. It's called special attack.

Spells use completely different table... Educate yourselves please - https://worldofwarcraft.fandom.com/et/wiki/Attack_table

Hunter should keep 5 stacks for a whole duration. (and Rogue, Warrior or anything that doesn't cast spells, so even Mage that only shoots wand should keep 5 stacks)

Echinaceax commented 4 months ago

Any attack that is not a white attack count as a spell. even the abilities from warriors and rogues are classed as spells

What??? This is so wrong, are you even serious?

we deem this working as it should

How can you deem this "working as it should" when your own 3 videos prove the opposite?

Trinket shouldn't lose stacks from any attacks at all... White, yellow, crit or non-crit... anything that requires weapon is an attack. Just because it's yellow and can do magic damage, doesn't mean it's a spell. It's called special attack.

Spells use completely different table... Educate yourselves please - https://worldofwarcraft.fandom.com/et/wiki/Attack_table

Hunter should keep 5 stacks for a whole duration. (and Rogue, Warrior or anything that doesn't cast spells, so even Mage that only shoots wand should keep 5 stacks)

As i told him in private, i am waiting for @keader to reply to me.

fvicaria commented 4 months ago

This has been removed to the private repo. We will deal with it.