search

WoWManiaUK / Redemption

WoW-Mania - Redemption - 3.3.5 PvE Realm
https://wow-mania.com/
52 stars 29 forks source link

[Item] Solace of the Defeated not proccing Twice with Beacon of Light for Flash of Light or Holy Shock. #6194

Closed Bartok14 closed 4 months ago

Bartok14 commented 4 months ago

What is Happening: Solace of the defeated, the trinket from ToC 25HC is not proccing correctly for Flash of Light or Holy Shock while using Beacon of Light. It works fine for Holy Light.

What Should happen: It should have the passive proc twice while Beacon of Light is applied to a tank and you heal another target. This is how it's always supposed to work but it isn't proccing correctly for heals other than Holy Light. It should be one proc for the original cast and a second proc for the Beacon of Light cast. Supposed to work similar to Meteorite Crystal.

Echinaceax commented 4 months ago

hi @Bartok14 thanks for reporting can you provide links for this report

Maine1 commented 4 months ago

From what I have found it shows that this only procs each time you cast a spell. Now when you cast holy light or flash of light of holy shock you are only casting 1 spell even though it is providing 2 since beacon is on the target. image

If you can provide any evidence to show otherwise we can look into this for you

Bartok14 commented 4 months ago

hi @Bartok14 thanks for reporting can you provide links for this report

Which links specifically do you need? I have one comment on Wowhead from 2010 you cna check out. If you need video evidence I'll need some time to provide that.

https://www.wowhead.com/item=47059/solace-of-the-defeated#comments Scroll to CTRI comment. Should work exactly like Meteorite Crystal which also procs with Beacon of Light spells.

Maine1 commented 4 months ago

I just checked meteorite crystal and if it works the same they have the same effect on casting spells. We will check if meteorite and if it procs the same we can go ahead on this

Bartok14 commented 4 months ago

From what I have found it shows that this only procs each time you cast a spell. Now when you cast holy light or flash of light of holy shock you are only casting 1 spell even though it is providing 2 since beacon is on the target. image

If you can provide any evidence to show otherwise we can look into this for you

For Holy Paladins Beacon has always counted as a second cast for heals. It's why Meterite Crystals was considered to be BiS most of the expansion. Because you could cast BoL on the tank and then spam FoL to stack up 2 stacks per heal.

Maine1 commented 4 months ago

Upon testing Meteorite Crystal I can confirm It is supposed to proc x2 Holy light, Flash of Light and Holy shock with beacon on but only when the beacon target is not healed directly. If the beaconed target is healed it should only proc 1 tick. With Solace of the Defeated however I came across this latest patch note. Now this is bad wording and unsure how this is supposed to react. image

It shows the change no longer effected by spells that cost 0 Base. Technically the second tick from the beacon didn't cost any base mana to tick.

Bartok14 commented 4 months ago

Upon testing Meteorite Crystal I can confirm It is supposed to proc x2 Holy light, Flash of Light and Holy shock with beacon on but only when the beacon target is not healed directly. If the beaconed target is healed it should only proc 1 tick. With Solace of the Defeated however I came across this latest patch note. Now this is bad wording and unsure how this is supposed to react. image

It shows that the change no longer effected by spells that cost 0 Base. Technically the second tick from the beacon didn't cost any base mana to tick.

I think this might have to do more with instant cast spell that actually cost 0 mana. Upon looking up Meteorite Crystal on Wowhead there was apparently some bugs where spells like Arcane Torrent would proc the trinket. Apparently casting Fishing would actually instand proc all 20 stacks as there is no global cooldown associated with fish casting. In this case Holy Light, Flash of Light, and Holy Shock would still cost mana to cast.

Maine1 commented 4 months ago

Yes I just read all that too. Find fish and Pet summons also. I did find this image Also says the same thing as solace of the defeated. Can go ahead with the fix.

Maine1 commented 4 months ago

@Rushor After a fair few hours I believe this can go ahead and work the same as Meteorite Crystal. Fix for Solace of the Defeated. normal and Heroic version and Solace of the Fallen normal and Heroic versions. proc 2x with Flash of light and Holy shock. When healing a target and Beacon of Light is on another target

Rushor commented 4 months ago

so we will copy the mechanic of Meteorite Crystal for Solace of the Defeated and Solace of the Fallen (nh + hc) yes?

Rushor commented 4 months ago

ah i see now: Code for Holy Shock while using Beacon of Light for those items is added manually, so we have to add code for those items here aswell

Maine1 commented 4 months ago

so we will copy the mechanic of Meteorite Crystal for Solace of the Defeated and Solace of the Fallen (nh + hc) yes?

Need to add proc twice when beacon is on another target for Holy shock and Flash of light. on all 4 items mentioned above.

Rushor commented 4 months ago

added same mechanic like Meteorite Crystal for Solace of the Defeated and Solace of the Fallen (nh + hc) 4 cases in total

Maine1 commented 4 months ago

@Rushor

Rushor commented 4 months ago

code was wrongly duplicated, should be fixed now

Maine1 commented 4 months ago

@Rushor

  • [x] Solace of the Fallen NM (ID 47271) - Holy shock is proccing 3 times without beacon & 6 times with. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Fallen NM (ID 47271) - Holy Light is proccing 2 times without beacon & 4 times with. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Fallen HC (ID 47432) - Holy shock is proccing 3 times without beacon & 6 times with. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Fallen HC (ID 47432) - Holy Light is proccing 2 times without beacon & 4 times with. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Fallen NM (ID 47271) Flash of Light is proccing 3 times with beacon. Should be 2 and only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Fallen HC (ID 47432) Flash of Light is proccing 3 times with beacon. Should be 2 and only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Defeated NM (ID 47041) Holy shock is proccing 3 times without beacon & 5 times with beacon. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Defeated HC (ID 47059) Holy shock is proccing 3 times without beacon & 5 times with beacon. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Defeated NM (ID 47041) Holy Light is proccing 2 times without beacon & 4 times with. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Defeated HC (ID 47059) Holy Light is proccing 2 times without beacon & 4 times with. Should be 1. Only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Defeated NM (ID 47041) Flash of Light is proccing 3 times with beacon. Should be 2 and only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
  • [x] Solace of the Defeated HC (ID 47059) Flash of Light is proccing 3 times with beacon. Should be 2 and only 2 when a Beacon is on a target in the party/raid group and the target with the beacon is not being healed directly.
Rushor commented 4 months ago

added one more mechanic from Meteorite Crystal (the procc attribute) lets see if that fixes it

Maine1 commented 4 months ago

@Rushor Seems to have done the trick all checked and working