[ICC] - Frost Giant weekly quest missing

[Maine1]

Links: https://www.wowhead.com/wotlk/quest=24871/securing-the-ramparts

What is Happening: NPC Skybreaker Lieutenant Is not at the start of ICC on 25 Nm + HC versions of ICC. Position

I believe it is on 10 Nm but not sure about 10HC (will need checking inside DB) There should also be the same NPC spawned at the Rampart of Skulls in position. This is currently not working for alliance only. Horde seems to work without issues.

What Should happen: NPC Skybreaker Lieutenant should be at the start of ICC on that weekly rotation and have quest https://www.wowhead.com/wotlk/quest=24871/securing-the-ramparts available

After help with looking an old report was found. https://github.com/WoWManiaUK/Redemption/issues/5702

Seems like Securing the ramparts was removed for some difficulties by the looks of this report instead of working as intended. Also looks like testers at the time didn't recheck everything!

[Rushor]

thos quest are rotating

they only spawn when the quests are active:

WeeklyQuest const WeeklyQuestData[WeeklyNPCs] = { {NPC_INFILTRATOR_MINCHAR, {QUEST_DEPROGRAMMING_10, QUEST_DEPROGRAMMING_25 }}, // Deprogramming {NPC_KOR_KRON_LIEUTENANT, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ROTTING_FROST_GIANT_10, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ROTTING_FROST_GIANT_25, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ALCHEMIST_ADRIANNA, {QUEST_RESIDUE_RENDEZVOUS_10, QUEST_RESIDUE_RENDEZVOUS_25 }}, // Residue Rendezvous {NPC_ALRIN_THE_AGILE, {QUEST_BLOOD_QUICKENING_10, QUEST_BLOOD_QUICKENING_25 }}, // Blood Quickening {NPC_INFILTRATOR_MINCHAR_BQ, {QUEST_BLOOD_QUICKENING_10, QUEST_BLOOD_QUICKENING_25 }}, // Blood Quickening {NPC_MINCHAR_BEAM_STALKER, {QUEST_BLOOD_QUICKENING_10, QUEST_BLOOD_QUICKENING_25 }}, // Blood Quickening {NPC_VALITHRIA_DREAMWALKER_QUEST, {QUEST_RESPITE_FOR_A_TORNMENTED_SOUL_10, QUEST_RESPITE_FOR_A_TORNMENTED_SOUL_25}} // Respite for a Tormented Soul };

[Rushor]

for future fix:

SELECT * FROM pool_quest WHERE entry IN ( 24874, 24869, 24873, 24872, 24870, 24871, 24879, 24875, 24878, 24880, 24876, 24877);

SELECT * FROM pool_quest WHERE pool_entry IN ( 5682, 5685, 5685, 5684, 5683, 5681, 5687, 5690, 5690, 5688, 5686, 5689);

[Maine1]

@Rushor if you didn't change anything in the code then it is still broken. They are rotating for the rest but not the 1 mentioned above. When that quest is on the weekly there is no NPC spawning for it

• [x] Works perfect for horde
• [ ] Broke for alliance

[Maine1]

thos quest are rotating

they only spawn when the quests are active:

WeeklyQuest const WeeklyQuestData[WeeklyNPCs] = { {NPC_INFILTRATOR_MINCHAR, {QUEST_DEPROGRAMMING_10, QUEST_DEPROGRAMMING_25 }}, // Deprogramming {NPC_KOR_KRON_LIEUTENANT, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ROTTING_FROST_GIANT_10, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ROTTING_FROST_GIANT_25, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ALCHEMIST_ADRIANNA, {QUEST_RESIDUE_RENDEZVOUS_10, QUEST_RESIDUE_RENDEZVOUS_25 }}, // Residue Rendezvous {NPC_ALRIN_THE_AGILE, {QUEST_BLOOD_QUICKENING_10, QUEST_BLOOD_QUICKENING_25 }}, // Blood Quickening {NPC_INFILTRATOR_MINCHAR_BQ, {QUEST_BLOOD_QUICKENING_10, QUEST_BLOOD_QUICKENING_25 }}, // Blood Quickening {NPC_MINCHAR_BEAM_STALKER, {QUEST_BLOOD_QUICKENING_10, QUEST_BLOOD_QUICKENING_25 }}, // Blood Quickening {NPC_VALITHRIA_DREAMWALKER_QUEST, {QUEST_RESPITE_FOR_A_TORNMENTED_SOUL_10, QUEST_RESPITE_FOR_A_TORNMENTED_SOUL_25}} // Respite for a Tormented Soul };

From Above code -

• [ ] Skybreaker Lieutenant missing

[Maine1]

{NPC_SKYBREAKER_LIEUTENANT, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }}, // Securing the Ramparts {NPC_ROTTING_FROST_GIANT_10, {QUEST_SECURING_THE_RAMPARTS_10, QUEST_SECURING_THE_RAMPARTS_25 }},

I added this as a section to apply the alliance NPC named - Skybreaker Lieutenant

Please check code for errors incase its not right before applying @Rushor

[Rushor]

the issue that could be, is that creature NPC_SKYBREAKER_LIEUTENANT has not a spawnpoint. it's basically only NPC_KOR_KRON_LIEUTENANT which gets updated to NPC_SKYBREAKER_LIEUTENANT - but let#s give it a try! good idea

[Maine1]

@Rushor https://github.com/WoWManiaUK/Redemption/issues/5702 Whatever was changed here in this section changed the quest to never show up maybe it was set to 2 instead of 1 because as you previously mentioned Skybreaker Lieutenant is a copy spawn of Kor'kron Lieutenant

https://github.com/WoWManiaUK/Redemption/issues/5702#issuecomment-1033046488 with skybreaker being a copy of Kor-kron maybe this is why it was set to 2 instead of 1!