WofWca / jumpcutter

⏩ Fast-forwards long pauses between sentences — watch lectures ~1.5x faster (browser extension)
https://chrome.google.com/webstore/detail/jump-cutter/lmppdpldfpfdlipofacekcfleacbbncp
GNU Affero General Public License v3.0
356 stars 13 forks source link

Video element controls keep appearing on each silence skip #117

Open WofWca opened 2 years ago

WofWca commented 2 years ago

Problem: when using the experimental algorithm (as well as desync correction), when a seek is performed, the controls fade in for ~2 seconds, which may be distracting to people.

It doesn't happen if you remove the controls, so maybe we could add a checkbox that removes them, at least for the local file player:

https://github.com/WofWca/jumpcutter/blob/81b4e507b68d9f7c50e90161326edc65038ae28c/src/entry-points/local-file-player/App.svelte#L89

It would make it a pain to seek the media if you don't use hotkeys though.

Can we maybe hide them just for the moment when the seek is performed?

In the future we could put this checkbox in the popup or something like that so you can hide controls on regular websites. Also maybe we could hide the controls only if the element is not focused.

WofWca commented 1 year ago

https://github.com/WofWca/jumpcutter/issues/154 is a clever idea, although I think it's bad for accessibility (e.g. keyboard users) if it's the only thing affecting the presence of controls. But it can make a great combo with what I suggested:

add a checkbox that removes them, at least for the local file player:

The local file player is a very simple app, so @lowwor, if you want, feel free to make an MR.

Zkffkah commented 1 year ago

Yeah, what I mean is for the local player, most custom video player on the web won't trigger the controls ui. Indeed, the show and hide of the controls doesn't effect the accessibility, it's the focus problem that forbid the keyboard action which needs to handle separately with custom keydown handler.