WofWca / jumpcutter

⏩ Fast-forwards long pauses between sentences — watch lectures ~1.5x faster (browser extension)
https://chrome.google.com/webstore/detail/jump-cutter/lmppdpldfpfdlipofacekcfleacbbncp
GNU Affero General Public License v3.0
356 stars 13 forks source link

improvement(settings): Change layout to be more readable #144

Closed jakubiakdev closed 1 year ago

jakubiakdev commented 1 year ago

This might be a matter of personal opinion, but when I downloaded this extension today, the settings page was very difficult to read. I hope by adding a divider between options, and separating checkboxes/selects the settings page will be more readable at a glance.

Feel free to suggest changes about this new layout

WofWca commented 1 year ago

Great stuff!

Before/after Before: ![image](https://user-images.githubusercontent.com/39462442/219938005-e7d73128-280a-4643-b5e4-f03df98bff29.png) After: ![image](https://user-images.githubusercontent.com/39462442/219938040-7ea869aa-65bb-4327-8966-f593c57c7d0c.png)

Please see if you like the changes I pushed.

Since now the label and the input are further apart, I think we need to make the checkboxes more visible or something:

image

Also when dealing with 2-dimensional elements, I prefer flex over grid. Also adding flex-wrap may make sense for narrower screens.

Also I think we need to center the contents between dividers better.

But that can be done later.

jakubiakdev commented 1 year ago

LGTM

WofWca commented 1 year ago

Great! Thanks a lot!