WofWca
commented
5 months ago Ok, I have a concrete plan for a start:
- [x] Introduce "advanced settings" toggle #86
- [x] Introduce a new translation string for the "volume threshold" value, something like "how much to skip", "amount to skip", "skip less / skip more". Keep the old string, and use the new string by default, when "advanced settings" are off
- [x] Hide "margin before" and "margin after" by default. (BTW what should we set their values to when they're hidden? Just set to defaults. makes sense). Perhaps even "silence speed".
- [ ] Hide the "silence speed" when "experimental" is active and "advanced" is off.
- [x] Hide the "regular speed" input when "I want to control playback rate (sounded speed) through the website's UI" is selected in options (which is the default). Also add an option to still show the input when
- [ ] Consider making the "⚙" open a drop-down, with options "show advanced options" and "settings".
- [x] Keep the things as is for the users that already have the extension installed.
To new and potential users the popup probably looks pretty scary. "Speech loudness"?? "Margin"??? Wat? Can't we just have one slider that is just marked "slower vs faster" ("skip more vs skip less")?
I think we can. We can make this slider control all the relevant parameters, including
volumeThreshold,silenceSpeed,marginAfter. Just make the value of each of the concrete setting a function (probably linear) of the said single input.This approach has been sighted in an FL Studio plugin called "Soundgoodizer":
Related: #157, #108, #110, #46.