WofWca / jumpcutter

⏩ Fast-forwards long pauses between sentences — watch lectures ~1.5x faster (browser extension)
https://chrome.google.com/webstore/detail/jump-cutter/lmppdpldfpfdlipofacekcfleacbbncp
GNU Affero General Public License v3.0
356 stars 13 forks source link

"Open popup" (Ctrl + Shift + Space) shortcut pauses the video on YouTube #170

Open WofWca opened 6 months ago

WofWca commented 6 months ago

I didn't used to be the case I think like a year ago.

I suspect this is related to the fact that if you execute the shortcut (press the keys), then keypress and keydown events are not dispatched to the currently active tab, but keyup does. Try it:

document.addEventListener('keydown', console.log)
document.addEventListener('keyup', console.log)
document.addEventListener('keypress', console.log)

Workaround

Keep "Spacebar" down until the popup gets opened.

Solution

Should probably report this to Chromium or what?

An alternative is to use a different key (not space). Ctrl + Shift + X is meh. I think it's already occupied in Firefox. Though what's wrong with having them different in Firefox and Chromium?