search

WofWca / jumpcutter

⏩ Fast-forwards long pauses between sentences — watch lectures ~1.5x faster (browser extension)
https://chrome.google.com/webstore/detail/jump-cutter/lmppdpldfpfdlipofacekcfleacbbncp
GNU Affero General Public License v3.0
337 stars 12 forks source link

Hide the badge (and darken the icon?) if there is no video #33

Open Hypfer opened 2 years ago

Hypfer commented 2 years ago

I've just installed and tested this extension. It works great! The only thing I don't like about it is that green badge which is very green.

image

Maybe changing the color scheme to match the one seen on the uBlock Origin icon? Or maybe also hide the badge entirely if there is no video element on the page?

Maybe even both things?

https://github.com/WofWca/jumpcutter/blob/ce5ac8e5b0a2a46d10900f6559724c5ab83264f6/src/background/initIconAndBadgeUpdater.ts#L15-L26

I see that there's a TODO there. What does DRY mean in that context?

Hypfer commented 2 years ago

After scrolling a bit further down in that initIconAndBadgeUpdater.ts, I've found settings.badgeWhatSettingToDisplayByDefault

image

Issue solved. The green is still very green though

It might make sense to reorder the settings page so that the simple options such as the badge one come before that huge blob of keyboard hotkeys, as - at least in my experience a few minutes ago - those pretty much made me tune out entirely

WofWca commented 2 years ago

Feels good to solve issues before they even start existing 😎

DRY means "don't repeat yourself", thought maybe these colors should be the same as the chart colors.

The green is still very green though

In what sense? Poor contrast? Too bright and distracting?

so that the simple options such as the badge one come before that huge blob of keyboard hotkeys

Yeah, the options page looks like it could used some work. However I thought that the hotkeys are more important that the badge, therefore they should go first.

Hypfer commented 2 years ago

Too bright and distracting?

Yeah, that one. For me It's constantly drawing attention even though nothing is happening that would require any.

WofWca commented 2 years ago

Actually I think that option is not enough, because you may want the badge to always display something, but only when there's a video.

WofWca commented 3 months ago

Manifest V3 adds per-tab badge and icon support. This should be easy to implement now.

So I suppose we could set the default icon to the darkened one and then if on this page we find the video then set the icon and the badge. Because a single tab can have several videos, plus several iframes.