Add Misc.setWindowTitle/Icon

WohlSoft / LunaLua

LunaLua - LunaDLL with Lua, is a free extension mod for SMBX 1.3 game engine, core of the X2 project.

https://codehaus.moe/

GNU General Public License v3.0

33 stars 12 forks source link

Add Misc.setWindowTitle/Icon #36

Closed MrDoubleA232 closed 2 years ago

MrDoubleA232 commented 2 years ago

Added these two functions as a test. One notable thing is that setWindowTitle does not work correctly with unicode characters, but I'm not sure how to fix that, unfortunately.

Also requires this change to ffi_misc.lua.

Wohlstand commented 2 years ago

One small tip against unicode:

Lua files must be saved with UTF8 encoding without BOM
After calling the thing, convert UTF8 into UTF16 using existing calls (there is Str2WStr(), and pass into WinAPI call variant with W ending， like "SetWindowTextW()" (seems already, except the wrong way to convert UTF8 into UTF16)

MrDoubleA232 commented 2 years ago

Hate to bump this stuff, but.. there doesn't seem to be any obvious solution to fix the issues here, so I'm wondering if it'll just end up scrapped or make it in?

Bluenaxela commented 2 years ago

It should make it in in some form at least. After I get some other things I'm in the middle of done I'd like to take a look myself to see if I can try some things a quick try maybe.

Bluenaxela commented 2 years ago

I figured out how to make unicode window titles work properly, no more "???" 🙂 As of 8f1283430f06760047d5441dae5ffb8c285a9f62 this has now been merged (manually rather than via pull request, but preserving the relevant change history).