Bluenaxela
commented
2 years ago Misc.runWhenUnfocused(bool): is probably mostly fine in concept, except that setting gMainWindowFocused = true; when calling with false causes messy behavior where if the window is unfocused, the user would have to manually focus then unfocus the window again to get it to pause properly. This is not good. When setting "runWhenUnfocused" to false, the game should pause if it's unfocused without any additional fiddling around. The best fix to this is changing the way gStartupSettings.runWhenUnfocused works, so it doesn't prevent setting gMainWindowFocused to false, but instead the places that currently check gMainWindowFocused should probably check gMainWindowFocused || gStartupSettings.runWhenUnfocused.
Misc.toggleFullscreen() seems seems like a questionable idea conceptually, particularly on it's own. Think about the use cases for a moment. Why would code want to toggle the fullscreen state, without knowing the current state? It's fair enough for a menu to have a "toggle fullscreen" option, but surely such a menu option should be implemented as some sort of toggle with a visual indication of what the current state is. That's just common sense user interface design. I can think of no good reason for code to want to toggle fullscreen without also being desirable to query fullscreen state, and if code is able to query that, it sure seems like it'd be more simple and versatile to have a Misc.setFullscreen(bool) instead.
In addition as a more minor thing, there is some inconsistent indentation.
SolaceEllery
MrDoubleA232
Up for showcasing today is a new pull request by me. Hopefully it's enough to meet some of SMBX2's standards.
It needs the following lines added to ffi_misc.lua.
Misc.setFullscreen(bool): Toggles the state of fullscreen without using maximize/window clicking. Set it to true to enable fullscreen, set it to false to disable fullscreen. Toggling it off while it's off or on while it's on won't do anything. Misc.runWhenUnfocused(bool): Set it to true if you want it to run when unfocused. Set it to false to set it to not run when unfocused. Misc.isFullscreen(): Returns true or false if it's in fullscreen mode.