search

WohlSoft / LunaLua

LunaLua - LunaDLL with Lua, is a free extension mod for SMBX 1.3 game engine, core of the X2 project.
https://codehaus.moe/
GNU General Public License v3.0
33 stars 12 forks source link

Fix CAPS Lock issue #56

Closed SolaceEllery closed 1 year ago

SolaceEllery commented 1 year ago

Today, I decided to make this a pull request. This was branched and edited a while back, but I didn't decide on making this a pull request until now, so there's that.

This pull request fixes the CAPS Lock issue by bringing back the KeyHOOKProc removed from many commits ago. Only except, KeyHOOKProc only has information about the CAPS Lock key so that the newer key system can be used for everything else.

I doubt this commit will go through, but oh well. I tried my best anyway.

Bluenaxela commented 1 year ago

There was no reason to bring back KeyHOOKProc. It's unnecessary complication and hooks have a little overhead.

I've made a fix which doesn't involve that in ba5ad55. It also handles the toggle states for num lock and scroll lock, which doesn't matter for typing, but ensures future Lua code reading key state will be able to see see all toggle states, not just caps lock.