search

Wohlstand / ADLMIDI-Player-Java

Simple MIDI-player for Android based on libADLMIDI library
https://play.google.com/store/apps/details?id=ru.wohlsoft.adlmidiplayer
MIT License
30 stars 1 forks source link

please remember to increase versionCode #4

Closed IzzySoft closed 5 years ago

IzzySoft commented 5 years ago

All APKs attached to releases/ have versionCode:1. That's not proper: Android uses that variable to tell updates (so currently there are none). Could you please (starting with the next release) increase that number? Must just be numeric and larger than the previous one. You can use that as "number of releases", or whatever you like – as long as it's bigger than that from the previous version :wink:

Thanks!

Wohlstand commented 5 years ago

Oh, thanks for note that it's the counter of releases, but not a "major version" number :fox_face: Will update it in next time ;3

IzzySoft commented 5 years ago

Thanks, @Wohlstand – and yes, the easiest use is "release counter". Some projects use it like "major10000 + minor100 + patch", to e.g. map "v2.1.3" to "20103". Works as well, as the resulting integer again is always bigger than the previous.

Background of my request: your app is in my F-Droid compatible repository. For users to be notified of updates … well, see above :wink:

PS: With the versionCode fixed, your app seems to meet all requirements to be listed at the official F-Droid repo. Would you like it to appear there? Just let me know, and I gladly assist you (disclosure: I'm one of the maintainers there).

Wohlstand commented 5 years ago

I see, anyway even this app isn't so perfect player that lacks playlists and things, and able to play only one song looped, but working example with real time tuning support that I use by myself to unit-test the libADLMIDI itself while I'm in the path :fox_face: :smile:

Gonna to apply recent fixes now...

Wohlstand commented 5 years ago

Okay, I have fixed this just now! :fox_face: :+1: Also, I have updated the libADLMIDI here, and, I gonna to upload my recent releases now

Wohlstand commented 5 years ago

I also have updated similar OPNMIDI player app that does use of libOPNMIDI library which is based on YM2612 (OPN2) chip while this on YMF262 :wink:

IzzySoft commented 5 years ago

Cool! My updater picked v1.4.2 today – and will fetch future updates as soon as there's a matching tag with APK attached.

As for the official repo: Take your time. Ping me if you want your app listed, and I'll gladly assist you in the process of bringing it there.

Wohlstand commented 5 years ago

Thanks! :fox_face: :smiley: Also, @IzzySoft , can you also add my OPNMIDI Player too? It's similar to this, but it using different chip to OPL3: it does use of OPN2 of libOPNMIDI that is here: https://github.com/Wohlstand/libOPNMIDI

Wohlstand commented 5 years ago

Anyway, as you confirmed the thing is done, I'll close this! :wink:

IzzySoft commented 5 years ago

Yupp! And done adding your other app. Will show up after the next sync (i.e. latest tomorrow evening, unless I trigger one manually – but I did that 3 times already today, so I don't want to confuse the #fdroid IRC channel with too many announcements :rofl:)

Thanks!

IzzySoft commented 5 years ago

Just a keep-alive (as this issue is closed; maybe we should open a separate issue for this) for bringing this app (or both apps) to the official repo :wink: