Wohlstand / OPL3BankEditor

A small cross-platform editor of the OPL3 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
143 stars 12 forks source link

Some percussion-mode tones aren't being played #166

Closed freq-mod closed 4 years ago

freq-mod commented 4 years ago

I made an experimental bank with use of OPL percussion mode. Instruments of "hi-hat" type aren't being played. At all - adlmidiplay throws error about missing percussion instrument. Yet they're present - in OPL3-BE you can preview them. Maybe it has something to do with being assigned to operator 1 rather than operator 2 (carrier) and synth doesn't know what to do about it YMF278.wopl.zip - bank file in question

Wohlstand commented 4 years ago

LOL, I see they have been detected as "silent" :zany_face: damn the measurer that didn't want to compute the length for rhythm-mode drums and they were been treated as silent. If you'll re-open the bank, you'll see those entries are marked as gray, and also, you'll see the computed sounding time is too short.

Wohlstand commented 4 years ago

Look: Снимок экрана от 2020-10-11 00-35-33

Wohlstand commented 4 years ago

I gonna fix this up at OPL3-BE side...

Wohlstand commented 4 years ago

... and therefore, I'll move the task to OPL3-BE side

Wohlstand commented 4 years ago

I made a fix just now, please run a full delays recomputation to make the fix work. P.S. Please don't change the "note offset" value together with a drum note, here is a small confusion at OPL3-BE itself that didn't resolve yet: note-offset doesn't work together with a drum note-number, but works at libADLMIDI.

freq-mod commented 4 years ago

Looks like that one is fixed, thanks, but I can hear another glitch with hi-hat note number affecting snare drum (?)

Let's take wikipedia's MIDI sample - YMF278.wopl.zip (contains also a bank with fixed delays and note offsets) after kick/snare solo sections that sounds properly, there is closed/open hihat solo. And after that, snare drum will become much higher in pitch, almost like a beep.

Wohlstand commented 4 years ago

Instruments except for bass drum (hi-hats and cymbals), using tom-tom's frequency channel to set own http://www.shikadi.net/moddingwiki/OPL_chip#Percussion_Mode

Wohlstand commented 4 years ago

At the same time, rhythm mode system itself needs an improvement

freq-mod commented 4 years ago

I see. But by "frequency" it's meant note number or just Frequency Multiplication parameter? Either way, yeah, percussion mode sounds weird but the main issue was fixed already. Thanks!

Wohlstand commented 4 years ago

I see. But by "frequency" it's meant note number or just Frequency Multiplication parameter?

Frequency is a tone frequency, resulted after the computation of note number, pitch bend factors, etc. FM chips do use the tone frequency in hertz value to define the note/tone.