search

Wohlstand / OPL3BankEditor

A small cross-platform editor of the OPL3 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
143 stars 12 forks source link

Messy, corrupted playback with a certain WOPL bank #183

Closed freq-mod closed 3 years ago

freq-mod commented 3 years ago

I don'tt know whether it's a bug on OPL Bank Editor side or libADLMIDI, but still... YM3812.wopl.zip - this is dmx_doom2.op2 (from OPL3BE bank examples folder) saved to .wopl format. However, it doesn't play how it should - any MIDI is completely messed up - pitches, octaves, notelenghts... difference is apparent when you compare it to bank nr 14 or 15.

freq-mod commented 3 years ago

UPDATE: when I saved the file with dmx_doom2.wopl name, it worked correctly. So, it's more likely OPL3-BE saving problem...

Wohlstand commented 3 years ago

Lemme try...

freq-mod commented 3 years ago

I just realized something - that corrupted playback is because the notes in the song being played have the same pitch. :eyes: bug.mp3.zip

Yet, there are a few instuments in this bank that don't suffer from this problem during playback, like Electric Piano 2 or Harpsichord

Wohlstand commented 3 years ago

Can you give me the MIDI file itself? btw, I guess that one of examples from Wikipedia, one of them I took a long time ago :fox_face:

freq-mod commented 3 years ago

yeah, it's wikipedia's example MIDI. and the problem is with every MIDI.

MIDITEST.zip - only these play fine, because they use only one instrument each - ele piano 2, harps, and clavi. Rest are broken

Wohlstand commented 3 years ago

Oh, I tried to use one of such files, with banks, and I see, what the heck? :thinking: I may guess, something got caused to set the "single-note" flag or .... gonna check :thinking:

freq-mod commented 3 years ago

A lil piece of info that may help - how I created this corrupted bank? - I took dmx_doom2.op2 bank, and saved it as .wopl, overwriting already existing bank.

Wohlstand commented 3 years ago

I found the reason - that because in original OP2 file there was lot of melodic instruments that had the "percussion note" being set non-zero, but when in WOPL bank the "percussion note" is set being non-zero at melodic instruments, it gets played with a fixed note. Mainly the mess of OPL3-BE. I am in process to resolve this...

Wohlstand commented 3 years ago

Just now I sent an update, it should work now. Also, it adds an ability to use the "Fixed Note" mode for melodic instruments which was unavailable, but in fact, this thing works for both OP2 and WOPL.

freq-mod commented 3 years ago

OK, disabled the fixed note flag solves the problem, thanks!