[Feature request] support Program Change events from MIDI In

Wohlstand / OPL3BankEditor

A small cross-platform editor of the OPL3 FM banks of different formats (Downloads in README below)

GNU General Public License v3.0

143 stars 12 forks source link

[Feature request] support Program Change events from MIDI In #212

Open tlubz opened 2 months ago

tlubz commented 2 months ago

MIDI In support is great, thanks so much for this tool!

One thing I'm missing is support for Program Change events from MIDI, which would potentially allow users to use this as a fully-fledged MIDI to OPL3 system, and play full MIDI songs on it, instead of one patch at a time.

Looking at GeneratorRealtime, I see that you support patch changes in real time, however it's only supported from the UX controller, and it Silences all playing sounds. It would be nice to add patch change support from MIDI In as well.

Wohlstand commented 2 months ago

This current implementation is made being extremely simple in order to just test the currently selected instrument. I thinking to just take my libADLMIDI as a backend to solve two cases:

allow your idea
have fully functional MIDI core without stripping out of the stuff
remove the duplication of runtime code (I have two different synth implementations at both OPL3-BE and libADLMIDI.

So, I'll keep your idea here until I'll take this for a work. For now I'm busy on other stuff.

tlubz commented 1 month ago

Thanks for the quick follow-up!

I looked into libADLMIDI, it looks like a cool project. For now I'm experimenting with the ADLPlug VSTi right now for my use-case, since it can work more closely with my DAW, and it supports multiple patch voices at once.

Then I can separately use OPL3BankEditor to edit and test sounds.