search

Wohlstand / OPN2BankEditor

A small cross-platform editor of the OPN2 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
40 stars 8 forks source link

[Feature Request]Option to show detune values as unsigned (0-7ε) #102

Closed freq-mod closed 3 years ago

freq-mod commented 3 years ago

Some FM tone editors/utilities and textual MML formats refer to detune values as unsigned numbers:

No detune can be either 0 or 4 1+ε = 1 1+2ε = 2 1+3ε = 3 1-ε =5 1-2ε = 6 1-3ε = 7 Also, Bamboo Tracker has such option.

Wohlstand commented 3 years ago

These are internal chip values, but signed values was taken from the manual. I would display both: internal and explanation what it means.

Wohlstand commented 3 years ago

Done! :fox_face: :+1: Peek 2020-11-28 14-59

freq-mod commented 3 years ago

Thanks! For consistency, 0 and 4 can be appended to "No change" labels, though.

Wohlstand commented 3 years ago

For consistency, 0 and 4 can be appended to "No change" labels, though.

I didn't that because the translation will give two copies of the label, otherwise, I'll make the code that does tr("No change") and filled the "0: %1" and "4: %1".