Wohlstand / OPN2BankEditor

A small cross-platform editor of the OPN2 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
42 stars 8 forks source link

Build error on delay_analysis.cpp #122

Open yohannd1 opened 2 years ago

yohannd1 commented 2 years ago

I'm trying to build the package on the AUR (package opn2bankeditor-git), and I've been having this error:

/home/yohanan/.cache/paru/clone/opn2bankeditor-git/src/OPN2BankEditor/src/delay_analysis.cpp: In member function ‘virtual double DelayAnalysisDialog::PlotData::y(double) const’:
/home/yohanan/.cache/paru/clone/opn2bankeditor-git/src/OPN2BankEditor/src/delay_analysis.cpp:250:15: error: cannot declare variable ‘spline’ to be of abstract type ‘QwtSpline’
  250 |     QwtSpline spline;
      |               ^~~~~~
In file included from /home/yohanan/.cache/paru/clone/opn2bankeditor-git/src/OPN2BankEditor/src/delay_analysis.cpp:29:
/usr/include/qwt/qwt_spline.h:57:18: note:   because the following virtual functions are pure within ‘QwtSpline’:
   57 | class QWT_EXPORT QwtSpline
      |                  ^~~~~~~~~
/usr/include/qwt/qwt_spline.h:176:26: note:     ‘virtual QPainterPath QwtSpline::painterPath(const QPolygonF&) const’
  176 |     virtual QPainterPath painterPath( const QPolygonF& ) const = 0;
      |                          ^~~~~~~~~~~
/home/yohanan/.cache/paru/clone/opn2bankeditor-git/src/OPN2BankEditor/src/delay_analysis.cpp:251:12: error: ‘class QwtSpline’ has no member named ‘setPoints’
  251 |     spline.setPoints(poly);
      |            ^~~~~~~~~
/home/yohanan/.cache/paru/clone/opn2bankeditor-git/src/OPN2BankEditor/src/delay_analysis.cpp:254:35: error: ‘class QwtSpline’ has no member named ‘value’
  254 |     double interpolatedY = spline.value(x);
      |                                   ^~~~~
make[2]: *** [CMakeFiles/OPN2BankEditor.dir/build.make:361: CMakeFiles/OPN2BankEditor.dir/src/delay_analysis.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:238: CMakeFiles/OPN2BankEditor.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'opn2bankeditor-git-1.3.beta.r80.g78c2a34-1':
:: Packages failed to build: opn2bankeditor-git-1.3.beta.r80.g78c2a34-1

Any clue on what this could be? I believe it's versioning related but I'm not sure what version of what program I should switch to.

Wohlstand commented 2 years ago

This module needs you the extra library being installed to make graphs.

yohannd1 commented 2 years ago

By extra library do you mean Qwt? If that's the case, I have it installed (qwt 6.2.0-1).

Wohlstand commented 2 years ago

Anyway, looking at error, I see, there is some incompatibility with Qt 6-based Qwt... Needs some fixes on here... :thinking:

freq-mod commented 1 year ago

Any progress?

Wohlstand commented 1 year ago

Good reminder, I'll try to check out this today. Recently I worked on Qt6 support at some place, and I could try it here too.

freq-mod commented 3 months ago

One year later, any progress?

Wohlstand commented 3 months ago

I'll try to take a look. Mostly this module was maintained by @jpcima, however, he doesn't appear for a while. So, I'll try to debug this by myself soon.