Notes are played at wrong pitch after modifying parameters

Wohlstand / OPN2BankEditor

A small cross-platform editor of the OPN2 FM banks of different formats (Downloads in README below)

GNU General Public License v3.0

40 stars 8 forks source link

Notes are played at wrong pitch after modifying parameters #32

Closed freq-mod closed 6 years ago

freq-mod commented 6 years ago

Steps to replicate:

Open any bank, select any instrument
Play any note, for example 76)
Change any paramenter, for example second operator's Decay 2 value (WARNING: you must do it by typing in values, using up/down UI buttons won't work)
Hit "Play note" button once again
That's it. Most of the time, note will be played at wrong pitch/octave. Changing previously modified parameter will give different results

This bug can be hard to replicate, since it seems to be very random. Tested on Nuked OPN2 core.

jpcima commented 6 years ago

Confirmed. Also it's only a thing of the UI interaction, it's not happening with the Midi keys. I trace a changeNote call which happens as number keys are typed with cursor in the edit box. Gotta solve the mystery about what causes this.

Wohlstand commented 6 years ago

Looks like is need to re-send the current note number and pitch to the chip on note play request...

jpcima commented 6 years ago

I found that only the key-release event is passed through to the piano when typing in an edit box. Out of this key-release the note is getting changed. I think, by arranging the piano to store the key states pressed by keyboard, I can then discard the unmatched key-release and not act the change of note.

freq-mod commented 6 years ago

Looks like it's fine now. Thnaks @jpcima!