search

Wohlstand / OPN2BankEditor

A small cross-platform editor of the OPN2 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
40 stars 8 forks source link

add PMDWin #67

Closed jpcima closed 5 years ago

jpcima commented 5 years ago

@papiezak added PMDWin as emulator choice

I had it in store for a while but not completed.. I cleaned up some warnings.

I don't think this one does SSG-EG

Wohlstand commented 5 years ago

Also, I think, you need to correct the volume level, I think, it's too high from this PMDWin, I have tested that myself, and one of instrument have got clipped while I played chords... And yeah, SSG-EG doesn't works on it :thinking:

Wohlstand commented 5 years ago

And, you have forgot to list it in benchmark (src/opl/measurer.cpp) (I have tried to benchmark it, but yeah, will add by myself, but will don't commit yet)

jpcima commented 5 years ago

Yes it has hearable clipping, I believed this happened internally. I will check. I will add PMDWin to the benchmark.

Wohlstand commented 5 years ago

2019-03-01 01-02-23 Wow, PMDWin has performance very closed to GENS :fox_face:

jpcima commented 5 years ago

Added soft panning. Since the multiplication needed would have overflowed the int32_t channel value, I moved the volume reduction which prevents clipping to a place further up.

I have seem to have problems of sticky notes on this emulator, in realtime play, which do not reproduce when using MAME.