adlmidi2: fix ADLMIDI2_VIDEO_OUT_SUPPORT for Windows

Wohlstand / libADLMIDI

A Software MIDI Synthesizer library with OPL3 (YMF262) emulator

GNU Lesser General Public License v3.0

170 stars 17 forks source link

adlmidi2: fix ADLMIDI2_VIDEO_OUT_SUPPORT for Windows #239

Closed HunterZ closed 3 years ago

HunterZ commented 3 years ago

I noticed that adlmidi2 has a CMake option ADLMIDI2_VIDEO_OUT_SUPPORT that enables support for piping video to ffmpeg, but that this isn't supported on Windows because of popen().

Turns out Visual C++ has a compatible implementation named _popen(), so I was able to get it working with a few additional minor tweaks: https://twitter.com/HunterZ0/status/1318735497951211521

I will submit a pull request for consideration.

Wohlstand commented 3 years ago

Thank you for the fix :fox_face: