Rework rhythm-mode percussions system

Wohlstand / libADLMIDI

A Software MIDI Synthesizer library with OPL3 (YMF262) emulator

GNU Lesser General Public License v3.0

174 stars 17 forks source link

Rework rhythm-mode percussions system #57

Closed Wohlstand closed 3 years ago

Wohlstand commented 6 years ago

Current rhythm-mode percussions system is bad:

Rhythm-mode drums in most are mapped incorrectly, there are working only in case of playing CMFs.
No way to use WOPL's and IBK's rhythm-mode percussions

What need to do:

Remove away percussionMap and store the rhythm-mode flags into the byte of flags (togeter with "no-sound" and "pseudo-4op")
Automatize AdLib percussions mode when using IBK-based bank, or when WOPL contains at least one drum with a rhythm-mode type.

Wohlstand commented 6 years ago

Began some work on editor side: https://github.com/Wohlstand/OPL3BankEditor/commit/58842631cac3a2a7c21df120d5156f48c95bef89 Now rhythm-mode drums are finally can sound, but hi-hats and cymbals still work incorrectly.

Wohlstand commented 6 years ago

Okay, Cymbals are working now, however, hi-hats are working on DosBox emulator, but silent on Nuked OPL3 and even on real chip tested on Windows 98 machine with SB16! Seems some commands are sent incorrectly...

freq-mod commented 5 years ago

On player (VLC plugin to be exact) side, I spotted interesting behaviour of cymbal-type percussion instruments - during playback, their timbre seems to change, or they sound differently than in bank editor. Example: https://instaud.io/3Cn7 - after crash cymbal (of normal FM percussion type) hi-hat's timbre changes a bit, sometimes difference is much more apparent. It doesn't happen on any other banks. I used Nuked 1.8, since other emulators have problems with percussion mode. adlib perc.zip - contains recording, .mid file, wopl bank and .opli instrument.

Wohlstand commented 5 years ago

Oh, forgot to check this task, it's made, but, yeah, it's now "polishing"

Wohlstand commented 4 years ago

Damn, I forgot to notice that not working cymbals was been fixed a while ago, so, they were working.

freq-mod commented 4 years ago

not working cymbals was been fixed a while ago, so, they were working.

Weird, on my side everything is still either broken or sounds incorrectly OPL2.zip - contains bank file, .mid sample and recording Note the wrong sounding snare and completely missing hi-hats, cymbals also sound differently in bank editor and during song playback btw. Maybe it has something to do with measurer bug in OPL3BE

Wohlstand commented 3 years ago

Hello! As the main topic of this task got solved, let's report any existing rhythm-mode problems at new issues?