search

Wohlstand / libOPNMIDI

A Software MIDI Synthesizer library with OPN2 (YM2612) emulator
GNU Lesser General Public License v3.0
96 stars 6 forks source link

MIDI2VGM: Passing a custom bank makes missing notes playing in dual-chip result #98

Closed Wohlstand closed 4 years ago

Wohlstand commented 4 years ago

When using midi2vgm and --chips 2 and relying on a default banks, result is usually fine. However, when we are passing a path to bank file, then, result gets a lot of missing instruments.

An example: koopa-kids2.mid.vgm.zip

Wohlstand commented 4 years ago

Fixed just now! https://github.com/Wohlstand/libOPNMIDI/commit/34ada670044425267158c84e4495d4a254a766eb

It was a very stupid mistake: I did dropped all data for second chip. The second chip obviously has no any output, therefore, it shouldn't be used for output, it should check that "I'm a second chip" and forward all data to first which actually has an output context.