Three-state filter to replace current filter

WojciechKrysiak / SCModManager

Stellaris mod manager - a simple mod reader/checker to find out which files are conflicting.

60 stars 6 forks source link

Three-state filter to replace current filter #25

Closed CatboyPrincess closed 5 years ago

CatboyPrincess commented 6 years ago

Replace the "selection only" filter with a filter that can display all mods, only selected mods, or only unselected mods.

Hacked together solution.

WojciechKrysiak commented 6 years ago

Commit looks good (and congrats on being my first contributor!). But there are 2 issues:

a minor one of naming convention - I prefer PascalCase, without underscore.
a major one of a complete rework in progress on the PortToAvalonia branch. I plan to clobber the master branch soon with the code present there

If you can, please apply your changes on that branch. If you have any problems with that, I'll re-apply them manually at some point in the future (i.e. next 2 weeks)

CatboyPrincess commented 6 years ago

Thank you! I will look into these issues.