search

WojciechMula / pyahocorasick

Python module (C extension and plain python) implementing Aho-Corasick algorithm
BSD 3-Clause "New" or "Revised" License
952 stars 125 forks source link

Test building on mingw #182

Open pombredanne opened 1 year ago

pombredanne commented 1 year ago

As follow up to https://github.com/WojciechMula/pyahocorasick/pull/175 we need to have some tests for the mingw build.

@pombredanne left a comment

Thanks! Do you think we could also run the tests in the CI for this? @nathaniel-daniel Author nathaniel-daniel commented Jan 14, 2023

Yes. The easiest method would involve installing an msys2 environment, installing the required packages, and building. I believe msys2 only works on Windows. How would you like that added to the test matrix? I assume you would want it added somehow to the "test_on_many_oses" action?

Adding to test_on_many_oses is the way.

nathaniel-daniel commented 1 year ago

Would you imagine a mingw as part of the build matrix or as an extension of the windows tests? It would be hard to introduce to the build matrix as a new dimension, as it can only be tested on windows and many matrix combinations would not be valid. I also don't think it can be added as an os as it isn't really an os. Introducing it as a step that is run only on windows might be easier, but failures in either the windows or mingw build would fail the entire windows build.