Wolfieheart / ArmorStandEditor-Issues

For all Issues of ArmorStandEditor-Reborn
1 stars 0 forks source link

Hook into Grief Prevention #36

Open RhinoCD opened 2 years ago

RhinoCD commented 2 years ago

Is your feature request related to a problem?

Yes, Players can grief other players armor stands with flint by editing the equipment of the armor stand and moving it in and out of other players claims

Describe the solution you'd like.

Make it so armorstands can't be edited unless you are trusted in the claim, can't bypass claims.

Describe alternatives you've considered.

-

Agreements

Other

No response

Wolfieheart commented 2 years ago

Already implemented on https://github.com/Wolfieheart/ArmorStandEditor/tree/dev/1.18.2-35 & https://github.com/Wolfieheart/ArmorStandEditor/blob/dev/1.18.2-35/src/main/java/io/github/rypofalem/armorstandeditor/protections/GriefPreventionProtection.java

Recommending to try that out and see if it works, also attempting to find a fix for the allowBuild Depreciation :)

RhinoCD commented 2 years ago

How do I download 35?

RhinoCD commented 2 years ago

Would it be the one in dev-builds Armorstandeditor-1.18.2-35pre2.jar? in the discord?

RhinoCD commented 2 years ago

After doing some testing, it does seem to hook, and it does detect that they are trying to edit a armor stand in a claim they shouldn't be in, however it does not prevent the user from using armor stand editor 2022-05-15_19 56 04 .

RhinoCD commented 2 years ago

As shown, I was able to still edit the armor stand in a protected area, with ignoreclaims off.

Wolfieheart commented 2 years ago

Glad that the implementation works, but wondering then what is the better alternative, will have to check around for the docs as I know allowBuild is depreciated.