search

Wolfieheart / ArmorStandEditor

Spigot/Paper etc. plugin to allow players to edit armorstands without commands.
GNU General Public License v3.0
28 stars 24 forks source link

[Bug]: Updating to 1.20.5 #494

Closed Jorrevdb closed 4 months ago

Jorrevdb commented 5 months ago

Expected behavior

Hi, i know it is soon, but i'm testing all my server plugins on 1.20.5, armorstandseditor gets disabled. This is my console: https://mclo.gs/rKIqSi2#L441

Observed/Actual behavior

https://mclo.gs/rKIqSi2#L441

Steps/models to reproduce

Update server to 1.20.5

Plugin list

[12:19:43 INFO]: Server Plugins (18): [12:19:43 INFO]: Bukkit Plugins: [12:19:43 INFO]: - AdvancedRegionMarket, ajLeaderboards, AlonsoLevels, ArmorStandEditor, AuctionGUIPlus, BetterRTP, ChatControlRed, Citizens, ClearLag, CMILib [12:19:43 INFO]: CoreProtect, FastAsyncWorldEdit, momojs, Multiverse-Core, PlaceholderAPI, Quests, Vault, WorldGuard

Plugin Version

[12:20:09 INFO]: ArmorStandEditor version 1.20.4-45 [12:20:09 INFO]: Allows players to edit data of armorstands without any commands. [12:20:09 INFO]: Website: https://www.spigotmc.org/resources/94503/ [12:20:09 INFO]: Authors: Wolfstorm, Wolfstorm, DreiFxn, Pinnkk, Kugge, Marfjeh, miknes123, rypofalem, sekwah41, Sikatsu1997, Cool_boy, sumdream, Amaury Carrade, nicuch, kotarobo, prettydude, Jumpy91, Niasio, Patbox, Puremin0rez, Prof-Bloodstone and PlanetTeamSpeak

Server Version

ver [12:20:29 INFO]: Checking version, please wait... [12:20:29 INFO]: This server is running Paper version git-Paper-6 (MC: 1.20.5) (Implementing API version 1.20.5-R0.1-SNAPSHOT) (Git: e16263c) You are running the latest version Previous version: git-Paper-496 (MC: 1.20.4)

Other

No response

Wolfieheart commented 5 months ago

Also noticed when testing with Paper JAR. Since the method that Paper uses to check for the MC Version isnt the same as Spigot and ASE depends on Spigot-API, I will have to find another way to do that check.

I also know how to check it if the user is on Paper. Will upload the fix to dev/1.20-46 and check if it works.

Wolfieheart commented 5 months ago

Alrighty fix is there but wont build. Gonna see what happens when I fix the build :)

Wolfieheart commented 5 months ago

OK now that I got my build fixed (with thanks to the PaperMC discord for helping me work out the issue exactly) - Can you check, if it has been fixed with: https://github.com/Wolfieheart/ArmorStandEditor/actions/runs/8868290622

Steps to get that working:

NOTE: that build is experimental and should not be used in production. Please let me know here via this issue if there are any extra errors.