WolfireGames / overgrowth

Open Source codebase of the game Overgrowth by Wolfire Games LLC
Apache License 2.0
2.51k stars 260 forks source link

Invalid data directory "Blend files" #35

Open feliwir opened 2 years ago

feliwir commented 2 years ago

My overgrowth data directory has an unused subfolder called Blend files with 3 files in it:

However release.xml only links the BlendFiles folder (which lives right next to that folder). Was that done by accident?

shinymerlyn commented 2 years ago

There are two different folders, one with a space in the name, one without. Sort of an "accident" that both folders exist, but the accident isn't a typo in the deployment stuff.

I find it a bit odd that we have access to mess with release.xml in this repo. It's purely a CI artifact.

image

feliwir commented 2 years ago

I know that there are two different folders - one of them is not used ("Blend files").

I find it a bit odd that we have access to mess with release.xml in this repo. It's purely a CI artifact.

It makes sense that release.xml is in this repository - so we can see things like this. It's not like we can modify it without a proper review, so i think we can't just mess with it.

shinymerlyn commented 2 years ago

It makes sense that release.xml is in this repository - so we can see things like this

Having visibility into it isn't necessarily a bad thing.

It's not like we can modify it without a proper review, so i think we can't just mess with it.

There isn't enough data with just this file to understand what's going on, let alone test any changes. So the ability to change it adds risk without providing much additional value, IMO. PRs also aren't a perfect gate.

Maybe there are some things that can be done to improve this by giving more access instead of revoking access. Maybe publishing a list of source content files would be one thing that could help. But as it currently stands I think it's a bit of a mixed bag as far as access provided, and it may lead to frustrating dead ends for contributors.

As in - do you currently have enough data and write access to alter all the steps in the CI pipeline and test it all out? If not, then maybe more access is necessary. Or maybe moving the CI portions out of this engine-specific repo makes more sense?

one of them is not used ("Blend files").

Both folders have contents for me. For me, Blend files has the contents you mentioned above. For me, BlendFiles has these contents:

Anims_ct
catrig.blend
cat_physics.blend
civrig.blend
dog_physics.blend
dualrigtest.blend
fancyrabbitrig.blend
female_rabbit_rig.blend
guard_physics.blend
handrig.blend
janner.blend
jannerhandrig.blend
lantern.blend
lantern.blend1
lt_dog_rig.blend
male_cat.blend
male_rabbit_rig.blend
new_female_cat_rig.blend
new_female_dog_rig.blend
new_female_rabbit_rig.blend
new_female_rat_rig.blend
new_female_wolf_rig.blend
new_male_cat_rig.blend
new_male_dog_rig.blend
new_male_rabbit_rig.blend
new_male_rat_rig.blend
new_male_wolf.blend
rabbit_dog.blend
rabbit_rat.blend
rabbit_rig.blend
rabbit_rig253.blend
raider_rig.blend
rat.blend
rat_physics.blend
torch.blend
turnerhandrig.blend
turnerrig.blend
wolfrig.blend
wolfrig2.blend
wolf_physics.blend
Anims_ct\catrig_Anims7.blend
Anims_ct\lt_dog_rig_Anims3.blend
Anims_ct\rabbit_rig_Anims13.blend
Anims_ct\rat_Anims3.blend
Anims_ct\wolfrig_Anims3.blend

It's possible I may have some leftover files from some older build, or I'm on a different branch than you. I believe the internal_testing steam beta branch has even more files than the none branch.

razvanab commented 2 years ago

Is there any chance the team will update the blender add-on to the latest version of blender ?

autious commented 2 years ago

Is there any chance the team will update the blender add-on to the latest version of blender ?

I found some unmerged work with a blender exporter for 2.93. It's on main now.

autious commented 2 years ago

I merged the Blend files folder contents into BlendFiles in the Auxiliary path.

talas commented 2 years ago

I see the 2.93 exporter push contains rabbit_rig.blend and rabbit_rig253.blend (in a zip file). Are these also open-souce?

autious commented 2 years ago

They are reference material to be used by modders, they aren't explicitally open source for reproduction use outside of overgrowth mods. You may contact wolfiregames to ask for permission however if you wish.