search

Wolfr / clank

Clank: open source prototyping framework for mobile apps
http://getclank.com/
Other
890 stars 81 forks source link

Use Bourbon instead of Compass #90

Closed nc closed 10 years ago

nc commented 11 years ago

Still working on this, but I thought I'd push it up so you could have a look.

kim3er commented 11 years ago

What's the benefit of using Bourbon over Compass? I really like Compass.

nc commented 11 years ago

@kim3er it's compatible with libsass / node-sass which is 40x faster than the Ruby sass compiler.

Compass is cool - but it's only being used very sparingly within Clank. The API / mixins are very similar.

kim3er commented 11 years ago

Interesting, I didn't know that. Will take a closer look at Bourbon.

Wolfr commented 11 years ago

Compass development (the mixins that is) seemingly has stagnated over the years so I'm not opposed to this.

I'll check out the changes.

On Fri, Aug 23, 2013 at 12:12 PM, Namit Chadha notifications@github.comwrote:

@kim3er https://github.com/kim3er it's compatible with libsass / node-sass which is 40x faster than the Ruby sass compiler.

Compass is cool - but it's only being used very sparingly within Clank. The API / mixins are very similar.

— Reply to this email directly or view it on GitHubhttps://github.com/Wolfr/clank/pull/90#issuecomment-23154846 .

Wolfr commented 11 years ago

Looking at the code I am sort of opposed with adding the full Bourbon library in as this will introduce a dependency I would need to update.

Is there a way to use bourbon without including it (so it reads the mixins from a compass plugin)?

On first thought I guess not since libsass probably works directly on the files and that's why it doesn't work with Compass which reads mixins from the ruby gem (I haven't used libsass/node-sass yet).

(Small thing, please remove the .takana-ignore files ;))

On Fri, Aug 23, 2013 at 12:14 PM, Richard Kimber notifications@github.comwrote:

Interesting, I didn't know that. Will take a closer look at Bourbon.

— Reply to this email directly or view it on GitHubhttps://github.com/Wolfr/clank/pull/90#issuecomment-23154902 .

nc commented 11 years ago

Yes. You can avoid having the bourbon files in the scss folder by using a Compass plugin like https://github.com/jedfoster/bourbon-compass

That means the project depends on Compass, Bourbon Compass and Bourbon.

Alternatively, if you use the raw Bourbon files which are update-able by running gem install bourbon && bourbon update the project would only depend on Bourbon and Sass (either Ruby Sass or libsass). Which was my original intent with this pull request - to ensure libsass compatibility.

nc commented 11 years ago

@Wolfr will remove them :)

Wolfr commented 10 years ago

Won't fix.

We are using Compass for now.