SideMenuItem currently only uses add icon

Wolfr / sveltekit-jui

Sveltekit-JUI is a kit of UI components to be used in conjunction with Svelte and Svelte Kit

https://sveltekit-jui-wolfr.vercel.app/

Other

44 stars 3 forks source link

Closed PaxPax closed 3 years ago

PaxPax commented 3 years ago

Currently the library is always using the add icon as seen here.

We should be using the the icon supplied by the user; also add .8rem style spacing to let the icon breath. Possible solution could look like.

I have a fix available, but wondering should the icon and spacing be two separate issues?

Wolfr commented 3 years ago

Logged something similar in #54 .

The whole project is in early phase so any improvement is welcome, just PR and I will take a look!

PaxPax commented 3 years ago

It would be helpful to have a contribute guideline as well!

Wolfr commented 3 years ago

Fixed it.