search

WolframResearch / FEMAddOns

Finite Element Method addons for Wolfram Language
Other
57 stars 14 forks source link

$defaultMaxIter definition missing #7

Closed szhorvat closed 5 years ago

szhorvat commented 5 years ago

It seems that in a commit made after the last release, the definition of $defaultMaxIter in FEMUtils.m went missing. This symbol is still being used here:

https://github.com/WolframResearch/FEMAddOns/blob/master/FEMAddOns/FEMUtils/Kernel/FEMUtils.m#L25

Offending commit:

https://github.com/WolframResearch/FEMAddOns/commit/10e6ee36d0cee87b6d3a35b15edd741eb5db2cb5#diff-7cc193883d597f26a74caa3caa6d7e17L25

I noticed this while browsing the sources using the IDEA Wolfram Language plugin, which warns about missing definitions.

ruebenko commented 5 years ago

Thanks a lot! Fixed with commit 7522a5ec1994727a8080d472740bc95f3c8c7f1c