WolframResearch / codeparser

Parse Wolfram Language source code as abstract syntax trees (ASTs) or concrete syntax trees (CSTs)
MIT License
123 stars 14 forks source link

Create workflow.yml #19

Closed bostick closed 4 years ago

kenkangxgwe commented 4 years ago

It will be great if you can provide the secrets to the actions so we may know whether it works or not.

kenkangxgwe commented 4 years ago

I think you can directly re-run the action in the webpage somewhere without making a new commit to trigger it.

cc-wr commented 4 years ago

@bostick, with respect to 1296e0f, I do not think the -activate option for wolframscript can take a value even though its help message says otherwise.

bostick commented 4 years ago

@kenkangxgwe Where would that be? I did not know about that

bostick commented 4 years ago

@cc-wr Do you have an example of what a succesfull script for authenticating and activating looks like?

kenkangxgwe commented 4 years ago

Only for failed actions: https://help.github.com/en/actions/configuring-and-managing-workflows/managing-a-workflow-run

kenkangxgwe commented 4 years ago

Btw, the original —activate worked for me. Wondering why WOLFRAM_AK is needed. Can it auto deactivates itself when the current instance of action is destroyed? Otherwise will it work on the next action that is triggered? Better to have a float license?

bostick commented 4 years ago

When you say the original -activate worked for you, I wonder what the precise sequence of steps was and how they are different than what the script is doing here. You can see in this run with the original -activate that it failed: https://github.com/WolframResearch/codeparser/runs/667036479?check_suite_focus=true

kenkangxgwe commented 4 years ago

It did not work because at that time you didn’t add the SECRETS. It worked on my fork with my SECRETS: https://github.com/kenkangxgwe/codeparser/runs/666237583?check_suite_focus=true at that step.

Btw, that failure was caused by not Exit[] at the end of script.

kenkangxgwe commented 4 years ago

Aha, do you have a valid Wolfram Engine license bound to your account?

bostick commented 4 years ago

Yes! That was the problem! I got the license setup, now the engine is working.

Running the tests should be comparatively easy...

szhorvat commented 4 years ago

I have never used GitHub Actions before. How exactly will this work when it's set up to run tests?

  1. Will the Wolfram Engine be re-installed every time the tests are run?
  2. Would that cause a problem with the license (we get only two licenses, as I understand)?
szhorvat commented 4 years ago

I also want to say thank you to both for trying to get this working! I wanted this for a long time, but I would never have gotten it set up alone.

bostick commented 4 years ago

For now, yes, will be re-installed each time. Will figure out a better solution if it causes problems.

Not sure about licensing. But the account that is being used for builds was created for this purpose, and hopefully will be able to accommodate whatever demands there are.