WolfyScript / CustomCrafting-Wiki

Wiki and JavaDocs for CustomCrafting
https://www.spigotmc.org/resources/55883/
9 stars 3 forks source link

Recipe book not working #24

Open Jorc0 opened 3 years ago

Jorc0 commented 3 years ago

Describe the bug My recipe book isnt working, tried lots of things, changed lots of things, restarted a few times, nothing worked. groups are shown, but recipes wont

To Reproduce Steps to reproduce the behavior:

  1. Go to '/recipes'
  2. Click on 'Recipe group'

Expected behavior Recipes should show up (wont)

Screenshots image image

Server:

Additional context https://anonfiles.com/zcS2J76cu3/recipe_book_1_json

WolfyScript commented 3 years ago

It might be because you have no filter set.

"filters" : {
    "sort" : [ ],
    "options" : [ {
      "id" : "search",
      "icon" : "COMPASS",
      "name" : "$recipe_book.filter.search.name$",
      "description" : [ ],
      "groups" : [ ],
      "namespaces" : [ ],
      "recipes" : [ ],
      "creativeModeTabs" : [ "SEARCH" ],
      "materials" : [ ]
    } ]
}

No sure if that is how it should work. I might change it so that if you set no filter, it displays everything.

Jorc0 commented 3 years ago

It might be because you have no filter set.

"filters" : {
    "sort" : [ ],
    "options" : [ {
      "id" : "search",
      "icon" : "COMPASS",
      "name" : "$recipe_book.filter.search.name$",
      "description" : [ ],
      "groups" : [ ],
      "namespaces" : [ ],
      "recipes" : [ ],
      "creativeModeTabs" : [ "SEARCH" ],
      "materials" : [ ]
    } ]
}

No sure if that is how it should work. I might change it so that if you set no filter, it displays everything.

But do i really need to set up filters?

Jorc0 commented 3 years ago

Might have found the issue


[11:49:03 INFO]: [CustomCrafting] Loaded fallback language "en_US" v5.0.0 translated by WolfyScript
[11:49:03 INFO]: [CustomCrafting] Loaded active language "en_US" v5.0.0 translated by WolfyScript
[11:49:03 INFO]: [CustomCrafting] Loading Recipes & Items
[11:49:03 INFO]: [CustomCrafting] - - - - [Local Storage] - - - -
[11:49:03 INFO]: [CustomCrafting] > customcrafting
[11:49:03 INFO]: [CustomCrafting] > vip
[11:49:03 INFO]: [CustomCrafting] > protes
[11:49:03 INFO]: [CustomCrafting] 
[11:49:03 INFO]: [CustomCrafting] Indexing Recipe Book...
[11:49:03 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing 'cc reload' in me.wolfyscript.customcrafting.commands.CommandCC(customcrafting)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:182) ~[patched_1.17.jar:git-Purpur-1255]
        at org.bukkit.craftbukkit.v1_17_R1.CraftServer.dispatchCommand(CraftServer.java:821) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCommand(ServerGamePacketListenerImpl.java:2316) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:2127) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:2108) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundChatPacket.handle(ServerboundChatPacket.java:46) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundChatPacket.handle(ServerboundChatPacket.java:6) ~[?:?]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:56) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1414) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.server.MinecraftServer.shouldRun(MinecraftServer.java:193) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1392) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1385) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[?:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1361) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1272) ~[patched_1.17.jar:git-Purpur-1255]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323) ~[patched_1.17.jar:git-Purpur-1255]
        at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "me.wolfyscript.utilities.util.NamespacedKey.getNamespace()" 
because the return value of "me.wolfyscript.customcrafting.configs.recipebook.RecipeContainer.getRecipe()" is null
        at me.wolfyscript.customcrafting.configs.recipebook.CategoryFilter.filter(CategoryFilter.java:61) ~[?:?]
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178) ~[?:?]
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?]
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
        at me.wolfyscript.customcrafting.configs.recipebook.Category.indexFilters(Category.java:54) ~[?:?]
        at java.util.HashMap$Values.forEach(HashMap.java:1067) ~[?:?]
        at me.wolfyscript.customcrafting.configs.recipebook.Categories.lambda$index$0(Categories.java:114) ~[?:?]
        at java.util.HashMap$Values.forEach(HashMap.java:1067) ~[?:?]
        at me.wolfyscript.customcrafting.configs.recipebook.Categories.index(Categories.java:112) ~[?:?]
        at me.wolfyscript.customcrafting.commands.cc_subcommands.ReloadSubCommand.onCommand(ReloadSubCommand.java:37) ~[?:?]
        at me.wolfyscript.customcrafting.commands.IndexCommand.execute(IndexCommand.java:32) ~[?:?]
        at me.wolfyscript.customcrafting.commands.CommandCC.execute(CommandCC.java:37) ~[?:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:172) ~[patched_1.17.jar:git-Purpur-1255]
        ... 20 more```
WolfyScript commented 3 years ago

Ok, I found the issue causing this issue and I will fix it. To fix this right now, try to remove the group "protes" so it is like "groups": [ ].

Jorc0 commented 3 years ago

The error on console is fixed, but recipes keep not showing up