search

WolfyScript / CustomCrafting-Wiki

Wiki and JavaDocs for CustomCrafting
https://www.spigotmc.org/resources/55883/
9 stars 3 forks source link

CC Removed enchantment glint from items that have the glint but no enchantments on it #52

Closed LadyHaley closed 2 years ago

LadyHaley commented 2 years ago

Describe the bug CC Removed enchantment glint from items that have the glint but no enchantments on it

To Reproduce Steps to reproduce the behavior:

  1. spawn an item with an enchantment glint
  2. put the item in any of the guis for CC
  3. no more enchantment glint Expected behavior A clear and concise description of what you expected to happen. The enchantment glint would stay, it helps to make custom items more distinct when using vanilla textures Screenshots If applicable, add screenshots to help explain your problem.

Server (please complete the following information):

Additional context Add any other context about the problem here. This didn't used to be the case last year

WolfyScript commented 2 years ago

What does the original nbt of the item look like? Does it has like null set for the enchants? I suspect that Bukkit does not support null enchants and therefor removes the glint. Basically the moment you place the item into the GUI it is updated by bukkit, which removes the glint, because the item doesn't have any enchants.

LadyHaley commented 2 years ago

It used to work fine with CC last year, I'm not sure what could have changed to break it

WolfyScript commented 2 years ago

I assume that Bukkit or Minecraft changed something, because I didn't really change anything. I encountered similar issues before where Bukkit no longer accepts setting custom entities on spawn eggs that are bound to a type. Unfortunately, I don't have control about that.

LadyHaley commented 2 years ago

I just checked, Mythic Mobs and Magic both also freak out when given the same item. as for the eggs, they both have custom eggs using the egg item I'm pretty sure, are you sure you cant have custom mob eggs?

WolfyScript commented 2 years ago

I think it's just when using for example creeper spawn eggs for another type of entity. Bukkit will instead convert the type of egg to the entity it contains. I am closing this issue now, because there isn't a way I can fix it, unfortunately.