WolfyScript / CustomCrafting-Wiki

Wiki and JavaDocs for CustomCrafting
https://www.spigotmc.org/resources/55883/
9 stars 3 forks source link

ItemsAdder - Removing meta from items #56

Closed SignorPollito closed 2 years ago

SignorPollito commented 2 years ago

Describe the bug When an ItemsAdder item with modified meta (name or lore, etc.) is put in a CustomCrafting GUI (example: when creating a custom recipe), the meta disappears.

To Reproduce Steps to reproduce the behavior:

  1. Create an item using ItemsAdder
  2. Modify its meta with a plugin
  3. Put the item in a CustomCrafting GUI
  4. The meta will disappear

Expected behavior The meta should not disappear when putting an itemsadder item

Video https://imgur.com/a/LpBgmg9

Server (please complete the following information):

Additional context Thank you for all your huge work on this plugin and on resolving problems/adding compatilibities with other plugins!

WolfyScript commented 2 years ago

This is intended as WolfyUtilities creates a reference to the saved item from ItemsAdder. This synchronises the ItemsAdder items with your recipes, so if you change the item in ItemsAdder they are updated automatically in the recipes. Plus, this improves the performance of the recipe check, because it only has to check if the items contain the ItemsAdder id. I recommend to edit the items in ItemsAdder itself.

If you still wanna disable this behavior you can do that in the WolfyUtilities/config.yml. Downsides:

You could bypass these downsides by saving the edited item via the ItemCreator and use the items from /cc give, but that's an extra step.

SignorPollito commented 2 years ago

Thank you, solved my problem! Closing this as it's not a bug.