WolfyScript / CustomCrafting-Wiki

Wiki and JavaDocs for CustomCrafting
https://www.spigotmc.org/resources/55883/
9 stars 3 forks source link

Cannot load correctly with itemsadder #68

Closed YKDZ closed 2 years ago

YKDZ commented 2 years ago

Describe the bug When I install ItemsAdder and CustomCrafting on the server at the same time, customcrafting does not work properly. When I remove ItemsAdder, CustomCrafting returns to normal. https://paste.ubuntu.com/p/NGj4f95yBM/

Server (please complete the following information):

Additional context I can't restore the error on the local server. Maybe it's due to other plug-in conflicts. I'll try to test it.

WolfyScript commented 2 years ago

It looks like invalid item NBT data. Are your enchantments you set for the items empty or null? If that is the case, you should remove the enchantment settings completely. Also weird that it only happens when ItemsAdder is installed.

YKDZ commented 2 years ago

It looks like invalid item NBT data. Are your enchantments you set for the items empty or null? If that is the case, you should remove the enchantment settings completely. Also weird that it only happens when ItemsAdder is installed.

I think I found the problem: I added some custom recipes for MMOItems, and then I removed these MMOItems, and then CustomCrafting became inoperable. So when I reset the CustomCrafting configuration file, everything returned to normal. What makes me wonder is, what does this have to do with ItemsAdder?

WolfyScript commented 2 years ago

Hmm, that indeed makes no sense... CustomCrafting does use an event from ItemsAdder to make sure the recipes are loaded after ItemsAdder, but that shouldn't interfere with this. In the error, I can see that it even fails to save the default recipes/items, caused by some serialization issue.

I added some custom recipes for MMOItems, and then I removed these MMOItems, and then CustomCrafting became inoperable. Regarding this issue. In 2.16+ recipes that contain invalid data, like empty items, are no longer loaded. That means this should no longer happen in the future.

I try to publish 2.16 for free soonish.

MrJorman commented 2 years ago

@WolfyScript https://github.com/PluginBugs/Issues-ItemsAdder/issues/1397