search

WolfyScript / CustomCrafting-Wiki

Wiki and JavaDocs for CustomCrafting
https://www.spigotmc.org/resources/55883/
9 stars 3 forks source link

ProtocolLib kills custom stonecutter recipes #83

Open gbl opened 2 years ago

gbl commented 2 years ago

Describe the bug When ProtocolLib is loaded, custom stonecutter recipes won't show in the stonecutter GUI and can't be crafted though they show up in the /recipes list. Removing ProtocolLib from plugins makes them work.

To Reproduce Steps to reproduce the behavior:

  1. Set up a new MC instance. I used paper-1.18.2-252 to do this.
  2. Install customcrafting-spigot-3.16.0.0-f.jar and wolfyutilities-3.16.3.2.jar
  3. Create two stonecutter recipes: 1 acacia plank -> 1 acacia stair; 1 acacia plank -> 2 acacia slabs
  4. Relog and use a stonecutter. Put an acacia plank into the input slot. Both recipes show up and can be used.
  5. Stop the server, install ProtocolLib from the Spigot site (which is 4.8.0; I had the same problem with build 551 from the CI site though), restart the server.
  6. Use the stonecutter - recipes don't show up and can't be crafted
  7. stop the server, remove ProtocolLib, start it again.
  8. Use the stonecutter - recipes reappear.

Expected behavior The configured recipes show up, and can be crafted, in the stonecutter GUI, no matter if ProtocolLib is installed or not.

Server (please complete the following information): Paper 1.18.2-252 Minecraft 1.18.2 Java 

openjdk version "17.0.1" 2021-10-19
OpenJDK Runtime Environment Temurin-17.0.1+12 (build 17.0.1+12)
OpenJDK 64-Bit Server VM Temurin-17.0.1+12 (build 17.0.1+12, mixed mode, sharing)

customcrafting-spigot-3.16.0.0-f.jar wolfyutilities-3.16.3.2.jar

Additional context

We had the same problem on our server with Paper 1.18.1, wolfyutilities-3.16.0.0.jar, and customcrafting-spigot-3.16.0.0-f.jar. Not knowing where the issue came from, we downgraded to wolfyutilities-1.8.0.0.jar and customcrafting-spigot-1.7.1.3f.jar, where the stonecutter worked as intended. Had to update Wolfyutilities when upgrading to Paper 1.18.2. though.

Lang5200 commented 2 years ago

I ran into the same problem,But I'm in Minecraft 1.17.1. I used the same version of the plug-in, but stone cutter still didn't work . Next, I remove ProtocolLib and it returns to work. Next, I install the ProtocolLib and it is miraculously not killed.

WolfyScript commented 2 years ago

I forgot to mention it here, but I recently released a new CustomCrafting update (v3.16.3.2), that should fix the issue.