WolfyScript / CustomCrafting

Spigot based plugin to create your own custom Recipes & Items. Designed to be easy to use with in-game GUI and tons of configuration possibilities.
https://modrinth.com/plugin/customcrafting
GNU General Public License v3.0
113 stars 36 forks source link

Problem when used by >1 Players #259

Closed xCraimax closed 1 year ago

xCraimax commented 1 year ago

What happened?

The Item can be duped, when using the cauldron by 2 or more players. I assume (not tested), that it can be duped more than once - depends on the amount of players.

How can the bug be reproduced?

Expected Behaviour?

Not duping and synchronizing between players.

Plugin version

CustomCrafting 4.16.6.0, WolfyScript 4.16.9.3

Server software

MC Paper 1.18.2

Relevant log output

No response

Submit issue

WolfyScript commented 1 year ago

Yep, that is indeed a major oversight. I'll have a look at how I can securely handle multiple viewers.

WolfyScript commented 1 year ago

I didn't find a way to synchronize the items between the GUIs reliably. So the fix for now will simply only allow one player at a time to view the cauldron GUI and block any other players from opening the GUI.