WolfyScript / CustomCrafting

Spigot based plugin to create your own custom Recipes & Items. Designed to be easy to use with in-game GUI and tons of configuration possibilities.
https://modrinth.com/plugin/customcrafting
GNU General Public License v3.0
113 stars 36 forks source link

Incompatibility with MMOItems vanilla recipe block #268

Closed Rastart21 closed 1 year ago

Rastart21 commented 1 year ago

What happened?

Can't take item from grindstone when using ingredients and result from mmoitems.

How can the bug be reproduced?

javaw_qDmoZMDmR8

javaw_wDIMj3MIas

Expected Behaviour?

Can take the result item

Plugin version

CostumCrafting: 4.16.7.0 Wolfy Utilities: 4.16.10.2

Server software

git-Paper-511 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 8d040fa)

Relevant log output

No response

Submit issue

WolfyScript commented 1 year ago

I looked into it and there seems to be the item option to disable repairing. It's called disable-repairing in the item config. Disabling it and updating the item/s worked in my case. Not the best solution as you can disenchant the item inside the grindstone, but it's the only way to do it at the moment.

I'll look how I can integrate something like a feature to properly support this.

Note to self: The listener conflicting can be found on the MMOItems repo. It checks both ingredients if they are disabled for repair. https://gitlab.com/phoenix-dvpmt/mmoitems/-/blob/master/MMOItems-Dist/src/main/java/net/Indyuce/mmoitems/listener/DisableInteractions.java#L47