QoL Improvements - Githubissues

Wolfyxon / MinVideo

Simple video format for limited environments

https://wolfyxon.github.io/MinVideo/js/test

The Unlicense

3 stars 3 forks source link

QoL Improvements #2

Closed Cracko298 closed 7 months ago

Cracko298 commented 7 months ago

Features of this PR:

Added a C++ implementation of the 'min_video' module, because I thought it was a little slow.
Added Progress Bar, and Estimated time till completion in the Python Variation of CLI.
No rework of the Module was conducted.
Pre-compiled C++ Binary *.dll and Source is included in the newly created ".\cpp" folder.
Binary is easily callable through 'ctypes' Library.

Compile Information:

Compiler:            MinGW w64
C++ Version:         C++ 11
Out Binary Type:     min_video.dll
Source File:         min_video.cpp
Build Command:       > g++ -shared -o min_video.dll -O3 -s min_video.cpp

Wolfyxon commented 7 months ago

Binaries shouldn't be in the source code. Delete the DLL please. Also the __pycache__ dir. Consider using git instead of uploading files via GitHub so the .gitignore file is respected.

Cracko298 commented 7 months ago

I'm submitting this through my Phone. Bad idea on my part 🤣, will update as soon as I can.

Cracko298 commented 7 months ago

Branch should be able to merge now, sorry about that. Updated .gitnore to match main repo.

Wolfyxon commented 7 months ago

Alright I'll do some testing now. Oh also, the get_rgb_data() function is unnecessary since the pixels property is public.

Cracko298 commented 7 months ago

Yes, I noticed the pixels property is publicly callable, and able to be referenced. This added function was apart of a parser to get color data, and reconstruct an image from a frame in the MinVideo Format. I took it out due to it being unusable in it's current state and most code relating to it.

Wolfyxon commented 7 months ago

Alright, all good. Merging, thanks.