Closed mutec closed 3 years ago
@mutec Thanks, this was helpful. The issue was simple, new sessions always created new legacy sessions. Only existing sessions re-used legacy sessions. Can you please review #4067 and check whether it fixes the issue for you?
@TimWolla I just did the changes over here and I'll have an eye on the list the next hours; it's working for new sessions only isn't it?
it's working for new sessions only isn't it?
After this change is applied it should no longer create duplicate legacy sessions (i.e. user online entries). Any existing duplicates should naturally expire 2 hours after the last activity (+ whatever delay the cleaner cronjob adds).
Reused sessions based on a valid cookie should not have created duplicates even without this change.
Until now it looks good. I just got the problems that I'm seeing sessions that get deleted by WCF::getSession()->delete();
before exiting the script which never happened before.
Do I have to do that in another way now or is it an unwanted side-effect?
Until now it looks good.
Okay, I'll merge that PR then. Thanks!
I just got the problems that I'm seeing sessions that get deleted by
WCF::getSession()->delete();
before exiting the script which never happened before. Do I have to do that in another way now or is it an unwanted side-effect?
Can we discuss this in a separate issue, please?
Sure, I'm checking that issue the next days since I'm working with the sessions anyway. :)
see also: https://www.cls-design.com/community/thread/18600-vorschau-woltlab-suite-5-4-vor-dem-update-ist-nach-dem-update/?postID=133605#post133605