search

WombatFromHell / OriginSteamOverlayLauncher

An executable wrapper for Steam to make third-party launchers more convenient to use with a Steam Controller
MIT License
412 stars 25 forks source link

Battle.net client broke URI launch #27

Closed dafzor closed 6 years ago

dafzor commented 6 years ago

The battlenet:// URI no longer launches the game, you can see bnetlauncher quick n' dirty hack in the altlaunch branch.

Just letting you know.

WombatFromHell commented 6 years ago

Thanks for the heads up. I'll get it fixed ASAP.

WombatFromHell commented 6 years ago

Fixed in commit fd4b5122. I really appreciate you pointing me to your workaround. Here's hoping Blizzard gets around to fixing their client internals.

dafzor commented 6 years ago

Even better workaround pointed to me in issue comments.

WombatFromHell commented 6 years ago

I agree, the second workaround is less hacky than the first. I'll implement it when I get some free time.

Thanks again for the heads up.

dafzor commented 6 years ago

Not sure it would require additional codding effort from you, maybe just some documentation changes on how to add battle.net client games.

WombatFromHell commented 6 years ago

It will probably take a bit of refactoring for OSOL to handle this sort of thing in a less brittle way. The way I'm handling URIs is very rudimentary right now as it assumes the launcher properly supports URI handlers and clearly Battle.net isn't behaving as it should. It's a little bit frustrating that the Battle.net launcher team decided that instead of fixing their URI handler support they've decided to move to another method of commanding their launcher that's more deeply wired (and probably also cross-platform rather than relying entirely on Windows' URI protocol support).

Either way, I'm in the process of revamping chunks of OSOL's process launcher code so I'll just toss this one on the pile. I don't mind the extra effort since the benefits will transfer to other launchers that don't properly behave with URI handlers.

WombatFromHell commented 6 years ago

This issue is addressed by commit 8a5f7483d017474c722d1ed732c74291b59f8fa7 which should be included in an upcoming point release due out in a few days. Again, the cross-project cooperation is extremely appreciated (excellent work pulling out the command strings by @Ethan-BB).

WombatFromHell commented 6 years ago

OSOL v1.07c with the commit mentioned above has been deployed so I'm going to go ahead and close this issue. Thanks again for the help @Ethan-BB and @dafzor.