Open lilyndk opened 2 weeks ago
@dricazenck let us know if you have other suggestions and/or if other codeowners should review this, before the task is assigned. :) Thanks
That was the previous functionality but have a look at this issue: https://github.com/WomenCodingCommunity/WomenCodingCommunity.github.io/issues/69 The menu functionality was changed to the current version to avoid the "duplication". @lilyndk
Also, if consistency is the main concern, we could create a similar landing page for when "Programmes" is clicked, we'd just need to figure out the content that goes on it.
Ah thanks for the info @khairahscorner
My main concern is the UX, i.e. that it's more common to have the dropdown simply open upon the click of the main nav link. Right now, users might think that the 'overview' pages don't exist if they just hover over the menu.
But if you know some good sites using the same nav pattern as we have implemented, please share. :)
istency is the main concern, we could create a similar landing p
I think that is a good idea, we can create programm landing page and should be fine.
Great.
Yeah I was also just looking at Google's material design guide, which is the design system we use. They use the proposed behaviour and it seems like this is also better accessibility-wise: https://m3.material.io/components/menus/accessibility. But I'm not an accessibility specialist so I also just asked Cathy to weigh in if she has input :)
Let's close this issue and it will be solved as part of #123
@dricazenck I'm re-opening this because several related 'nav accessibility' tickets' are being created.
Hi @sssoz, can you update the description in this issue to include the notes from the issue you reported in https://github.com/WomenCodingCommunity/WomenCodingCommunity.github.io/issues/143? And then just close issue #143 and make a note that it's a 'duplicate' of this issue. Thanks
Hi @PaulineNemchak, can you update the description in this issue to include the notes from the issue you reported in https://github.com/WomenCodingCommunity/WomenCodingCommunity.github.io/issues/139? And then just close issue #139 and make a note that it's a 'duplicate' of this issue. Thanks
It would be good to just fix all the related accessibility navigation issues in this one PR, since we need to change the main nav to include an 'overview page' link for the main landing pages (about us, etc.)
@lilyndk I unfortunately can’t edit this issue’s description!
@sssoz ah ok, I will update the description then to include the bugs you and @PaulineNemchak reported. :)
Description has been updated and this task is ready for development.
Bug Report
Describe the bug
Issues: 1) Dropdown does not follow common UX pattern with 'Overview' page link, resulting in confusion about what pages 'exist' when the dropdown is open.
2) Submenu links are not accessible from keyboard and missing aria attributes
3) Submenu items are not accessible on mobile
Acceptance Criteria
1) Update nav to include ‘Overview’ page links. If a user clicks on the main link (e.g. About Us), the behaviour should be that the dropdown simply opens upon the click, similar to Nielsen Norman Group:
2) Ensure that it is possible to open the submenu with the keyboard, e.g. using the arrow down key.