search

WomenInSoftwareEngineeringJP / speak-her-db

Database of women speakers in Japan.
https://speakher.jp
MIT License
25 stars 25 forks source link

Implement proper caching of Airtable requests (add state management?) #146

Open tuttiq opened 4 years ago

tuttiq commented 4 years ago

Is your feature request related to a problem? Please describe

The current caching logic doesn't work, so we're still making requests to Airtable to get the full list of prefectures, languages and topics every time we load the speaker list and the nominate form.

Since we shouldn't have any more N+1 requests problem, it's a not a huge deal right now, but could improve the performance slightly and more as we add more pages to the site in the future (speaker profile page, etc?).

Describe the solution you'd like

I think we should probably just add centralized state management with Vuex.

Describe alternatives you've considered

I tried a few workarounds for caching, but they all have problems (serializing/deserializing data, etc).

ann-kilzer commented 4 years ago

lolololol we should fix this, it's making the page load slower and slower as our userbase grows

SpeakHer
tuttiq commented 4 years ago

The short term solution is already implemented here: #144 .

This ticket is for a longer-term solution.